-
-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update regex to detect all variants of /* istanbul ignore */ comments #3217 #3220
Conversation
Caution Review failedThe pull request is closed. WalkthroughThis pull request encompasses two primary changes: an update to the code coverage disable check script's regular expression pattern and a migration of the Changes
Assessment against linked issues
Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Issue Number:
Fixes #3211
Description:
What Changed:
The regular expression in the code_coverage_disable_check.py script has been updated to ensure that all variants of the /* istanbul ignore / comment are detected. This includes:
/ istanbul ignore /
/ istanbul ignore next /
/ istanbul ignore line /
/ istanbul ignore next -- @preserve */
Snapshots/Videos: dummy test files to check that its working or not
If relevant, did you update the documentation?
N/A
Does this PR introduce a breaking change?
No
Other information
N/A
Summary by CodeRabbit
Tests
Chores