Skip to content

Add ocean world#129

Open
Jaeyoung-Lim wants to merge 2 commits into
mainfrom
pr-add-ocean
Open

Add ocean world#129
Jaeyoung-Lim wants to merge 2 commits into
mainfrom
pr-add-ocean

Conversation

@Jaeyoung-Lim

@Jaeyoung-Lim Jaeyoung-Lim commented Dec 11, 2025

Copy link
Copy Markdown
Member

Problem Description
This PR adds an ocean world that can be useful for testing boats

image

@Pedro-Roque Pedro-Roque left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need the gz::sim plugins and the buoyancy plugin in https://github.com/PX4/PX4-gazebo-models/blob/main/worlds/underwater.sdf ?

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, minus the license on the model.

Comment thread models/boat/model.config
<name>Boat</name>
<version>1.0</version>
<sdf version='1.5'>boat.sdf</sdf>
<license>Apache 2.0</license>

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we have a license issue here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think is the best way to address it? It is ported over from old gazebo.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to either change the license of this repo or we need to ask the original authors to relicense it for us

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll reach out to the authors and see if we can go in that direction.

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, minus the license on the model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants