Skip to content

Convert client.key to RSA format #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2025
Merged

Convert client.key to RSA format #2362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lighty-modules/lighty-gnmi/lighty-gnmi-connector/src/main/scripts/generate_certs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,4 +90,6 @@ openssl verify -verbose -CAfile ca.crt client.crt
echo ""
echo " == Validate Client with passphrase"
openssl verify -verbose -CAfile ca.crt client.encrypted.crt

echo ""
echo " == Transform Client from PEM to RSA format"
openssl rsa -in client.key -out client_new.key -traditional && mv client_new.key client.key
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a hardcoded temporary filename client_new.key can be problematic. If the script is interrupted or if multiple instances are run concurrently in the same directory, it could lead to race conditions or leave behind stale temporary files. It is safer to use a unique name for the temporary file, for example by incorporating the process ID ($$), to make the script more robust.

Suggested change
openssl rsa -in client.key -out client_new.key -traditional && mv client_new.key client.key
tmp_file="client.key.$$" && openssl rsa -in client.key -out "$tmp_file" -traditional && mv "$tmp_file" client.key

Loading