Convert client.key to RSA format

[ihrasko]

GNMI app cannot read PEM encoded client key. Our only option is to use RSA encoding.

GH issue: #2355

(cherry picked from commit 52076cd)

[gemini-code-assist]

Summary of Changes

Hello @ihrasko, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical compatibility issue with the GNMI application by modifying the certificate generation script to produce client keys in the required RSA format. This ensures that the application can correctly read and utilize the client keys, addressing a known functional limitation.

Highlights

• Client Key Format Conversion: The generate_certs.sh script has been updated to automatically convert the generated client.key from PEM to RSA format. This change is crucial for ensuring compatibility with the GNMI application, which cannot process PEM-encoded client keys.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a step to the generate_certs.sh script to convert the client.key to the traditional RSA format. This is a good change to ensure compatibility across different environments. My review includes one suggestion to improve the robustness of the script by using a unique temporary filename during the key conversion. This will prevent potential race conditions or issues with stale temporary files.

[gemini-code-assist]

Using a hardcoded temporary filename client_new.key can be problematic. If the script is interrupted or if multiple instances are run concurrently in the same directory, it could lead to race conditions or leave behind stale temporary files. It is safer to use a unique name for the temporary file, for example by incorporating the process ID ($$), to make the script more robust.

Suggested change

	openssl rsa -in client.key -out client_new.key -traditional && mv client_new.key client.key
	tmp_file="client.key.$$" && openssl rsa -in client.key -out "$tmp_file" -traditional && mv "$tmp_file" client.key