Open
Conversation
| - ubuntu is in the sudoer's list | ||
| - unmounted disks are clean - if your root is on one of partitions and you pass it as an argument, this could be disastrous | ||
| - The initial state of the machine is cleaner than others that we have tried | ||
| - Disks are named consistently (nvme01, nvme0n2) |
There was a problem hiding this comment.
Not always the case:
Mine are:
nvme0n1
nvme1n1
nvme2n1
| - unmounted disks are clean - if your root is on one of partitions and you pass it as an argument, this could be disastrous | ||
| - The initial state of the machine is cleaner than others that we have tried | ||
| - Disks are named consistently (nvme01, nvme0n2) | ||
| - Ubuntu installed (preferably ubuntu 20.04, 22.04) - this won't work with centos, etc. since they don't use aptitude by default |
There was a problem hiding this comment.
22.04 may not work as intended due to ondemand.service not existing. I am testing with 20.04 now
There was a problem hiding this comment.
It works as expected on Ubuntu 20.04
Will need to detect for the version and use an alternate method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.