chore(deps): move the workspace to the published head (trql-client 0.16, vta-sdk 0.35, TDK 0.13) - #38
Merged
Merged
Conversation
The registry has published through trql-client 0.16.0, which is what the
`rev` pin was scaffolding for. 0.16.0 declares `trust-tasks-rs ^0.18` — the
line vta-sdk 0.34 already resolves — so this goes back to a plain version
requirement and the workspace holds one copy of trust-tasks again:
trust-tasks-rs v0.18.11
├── affinidi-messaging-sdk -> affinidi-tdk -> {verify-trust, vta-sdk}
├── trql-client v0.16.0 -> verify-trust
└── vta-sdk v0.34.1
Previously 0.17.3 (via the pinned rev) and 0.18.6 sat in the tree together.
The lockfile now carries no git sources at all, so `publish.yml` can get
past the manifest on a release tag; a separate, older blocker remains, noted
below.
The 0.15.0 rev -> 0.16.0 diff touches only `trql-client/src/client.rs`, and
only to route builder failures through one `payload_build_error` helper. No
symbol verify-trust imports changed, and no source change was needed here.
0.16.0 also drops the AWS SDK's legacy hyper-0.14 client from the registry's
graph, and with it the h2 0.3 / rustls 0.21 advisories it was suppressing.
`cargo update` alongside it, which floats vta-sdk 0.34.0 -> 0.34.1 and
refreshes the usual transitive set (reqwest, rustls, tokio-rustls, uuid,
wasm-bindgen, zerocopy).
vta-sdk 0.35 and affinidi-tdk 0.13 are published and deliberately not taken.
The follow-never-lead rule in the manifest cuts both ways: OpenVTC is on
vta-sdk 0.34.1 / TDK 0.12, so moving here would put two vta-sdk copies in its
binary — the break that comment exists to prevent, caused from this side. It
would also re-split trust-tasks, since vta-sdk 0.35 wants ^0.19.4 against
trql-client 0.16's ^0.18. That bump belongs in the step where OpenVTC moves.
fmt, clippy -D warnings, check and all 136 tests pass. Two things this does
not fix, both pre-existing on main: `cargo audit` reports RUSTSEC-2023-0071
(rsa 0.9.10, via pgp 0.20 and ssh-key 0.6, no fixed version available), and
`cargo publish --dry-run -p verify-trust` fails because the published
vgi-core 0.4.7 predates `signer_did` / `conflicting_signer_dids` while the
packaged build resolves it from crates.io — vgi-core needs republishing
before any dependent can go out.
Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
|
🛡️ AI Agentic Security Code Review — all clear. We checked this change and found nothing to report. Keep shipping secure code! Note: for major, breaking, or feature-introducing changes, you can always request an in-depth review from the security team. |
VTI main is on this line (vta-sdk 0.35, TDK 0.13, trust-tasks 0.19.4) and the
trust registry merged onto it in #133, so this moves the workspace to the
published head rather than sitting a minor behind. No source change was
needed: this crate reaches the VTA through `connect_auto` and takes display
names, and names none of the types 0.35 changed.
This one *leads* the consumer instead of following it, which is the rule the
vta-sdk comment in this manifest otherwise exists to enforce. OpenVTC main is
still on vta-sdk 0.34.1 / TDK 0.12 / trust-tasks 0.18.5 with no branch in
flight, so until it moves, a build taking both this crate and vta-sdk directly
resolves 0.34.1 and 0.35.0 together — and `vti-common` re-exports
`vta_sdk::acl::{ActScope, ApproveScope, ContextDirection}`, so those copies
carry types that cannot unify. That was accepted deliberately to get this
workspace current; OpenVTC is to be moved separately, and the manifest records
it as a known, temporary break rather than a new licence to lead.
trust-tasks-rs splits again as a side effect — trql-client 0.16 declares ^0.18
while vta-sdk 0.35 declares ^0.19.4:
trust-tasks-rs v0.18.11
└── trql-client v0.16.0
└── verify-trust
with every other consumer on 0.19.4. That is the narrowed, historically
tolerated shape: verify-trust passes no trust-tasks type across trql-client's
HTTPS transport, and did-git-sign — the crate OpenVTC consumes — has no
trql-client edge at all (`cargo tree -p did-git-sign | grep -c trql` is 0), so
the duplicate never reaches a graph where a type has to unify.
trql-client 0.17.0 is the fix and is merged but not yet published (registry
d99228a, #133) — it declares ^0.19.4 and collapses the tree to one copy. It is
deliberately not taken as a git `rev`: that would re-block `cargo publish` at
the manifest, which the previous commit just cleared, to buy a duplicate that
is already tolerable. Bump to `"0.17"` when it reaches crates.io; the coupled
move was verified locally as clippy/test green with no source change.
fmt, clippy -D warnings, check, MSRV 1.95.0 and all 136 tests pass.
Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the workspace onto the published head of the stack. Two commits:
trql-clientgitrev→"0.16"— retires the pin now that the registry has published, and removes the last git dependency from the lockfile.vta-sdk0.34 → 0.35,affinidi-tdk0.12 → 0.13 — the line VTI main runs and the registry merged onto in #133.Plus
cargo updatefor the transitive set. No source change was needed for either step.Commit 1 — retire the git pin
trql-clientwas pinned to a gitrevbecause the last published version (0.14.0) declaredtrust-tasks-rs ^0.9against a stack on ^0.17. The registry has now published through 0.16.0. The rev → 0.16.0 diff touches onlytrql-client/src/client.rs, and only to route builder failures through onepayload_build_errorhelper — none of the symbolsverify-trustimports changed.cargo publishrejects git dependencies outright, sopublish.ymlcould not have got past the manifest on a release tag while the rev stood. That blocker is gone (see caveats for the one that remains).Commit 2 — vta-sdk 0.35 / TDK 0.13
mainmainOpenVTC is still a minor behind with no branch in flight. Until it moves, a build taking both
did-git-signandvta-sdkdirectly resolves 0.34.1 and 0.35.0 together — andvti-commonre-exportsvta_sdk::acl::{ActScope, ApproveScope, ContextDirection}as its own public API, so those copies carry types that cannot unify. OpenVTC needs a follow-up move to 0.35; that debt is the thing to clear next.Known duplicate
trust-tasks-rssplits as a side effect —trql-client0.16 declares^0.18,vta-sdk0.35 declares^0.19.4:with every other consumer on 0.19.4. This is the narrowed, historically tolerated shape:
verify-trustpasses no trust-tasks type acrosstrql-client's HTTPS transport, anddid-git-sign— the crate OpenVTC consumes — has notrql-clientedge at all (cargo tree -p did-git-sign | grep -c trql→0), so the duplicate never reaches a graph where a type has to unify.trql-client0.17.0 is the fix: merged upstream as registryd99228a(#133), declares^0.19.4, collapses the tree to one copy. It is not taken here as a gitrev— that would re-blockcargo publishat the manifest, which commit 1 just cleared, to buy a duplicate that is already tolerable. Bump to"0.17"when it reaches crates.io; I verified the coupled move locally (singletrust-tasks-rs0.19.4, clippy and tests green, no source change).Testing
cargo fmt --all --check,cargo check --workspace,cargo clippy --workspace --all-targets -- -D warnings,cargo test --workspace(136 pass), andcargo +1.95.0 check --workspacefor MSRV — all clean.Pre-existing, not fixed here
Both present on
main:cargo auditreports RUSTSEC-2023-0071 (rsa0.9.10 viapgp0.20 andssh-key0.6). No upstream fix available; not a CI gate.cargo publish --dry-run -p verify-truststill fails: the publishedvgi-core0.4.7 predatessigner_did/conflicting_signer_didswhile the packaged build resolves it from crates.io.vgi-coreneeds republishing before any dependent can go out.Follow-ups
vta-sdk0.35 / TDK 0.13 (clears the leading-the-consumer debt)trql-clientto"0.17"once published (collapses the trust-tasks duplicate)vgi-core(unblocks releases)