chore(release): bring the workspace to 0.4.8 so vgi-core republishes - #40
Merged
Conversation
0.4.7 cannot be released, and not for a reason a retry fixes. The partial
v0.4.7 run uploaded `vgi-core` 0.4.7 and then died on the `trql-client` git
dependency, leaving crates.io holding vgi-core 0.4.7 with content that predates
`signer_did` / `conflicting_signer_dids`, against verify-trust and did-git-sign
still at 0.4.6. `publish.yml` skips any crate already on crates.io at the
workspace version, so a second `v0.4.7` tag would skip vgi-core and then build
both dependents — each of which calls those two functions — against the stale
copy. That is the `E0432: unresolved imports` a dry run has been reporting.
The version is what makes vgi-core republish, so the fix is the bump. All three
crates take it through `version.workspace = true`; the internal requirement
moves with it.
The publish path is verified as far as it can be before a real upload:
- `cargo publish --dry-run -p vgi-core` packages and compiles clean
- `cargo publish --dry-run -p verify-trust` now fails only with "failed to
select a version for the requirement `vgi-core = ^0.4.8`", i.e. the
ordinary first-in-chain ordering that publish.yml handles by publishing
vgi-core first — no longer the stale-API error it gave at 0.4.7
This is the third step of the chain OpenVTC's manifest documents: the registry
published trql-client (0.17.0), VGI swapped its git pin back to a version
(#38, #39), and a tag here lets OpenVTC delete its `[patch.crates-io]` block
and floor did-git-sign at a published release instead of re-pinning a git rev
on every vta-sdk minor.
No dependency or source changes. fmt, clippy -D warnings, check, MSRV 1.95.0
and all 136 tests pass.
Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Workspace version 0.4.7 → 0.4.8. Two lines plus the lockfile; all three crates take it through
version.workspace = true.No dependency or source changes.
Why a bump rather than re-tagging 0.4.7
0.4.7 cannot be released, and not for a reason a retry fixes.
The partial
v0.4.7run uploadedvgi-core0.4.7 and then died on thetrql-clientgit dependency — the failurepublish.yml's own header comment describes. That left crates.io in a split state:vgi-coresigner_did/conflicting_signer_didsverify-trustdid-git-signpublish.ymlskips any crate already on crates.io at the workspace version. So a secondv0.4.7tag would skipvgi-coreand then build both dependents against that stale copy — and both call those two functions. That is theE0432: unresolved importsa dry run has been reporting all along.The version number is the only thing that makes
vgi-corerepublish, so the bump is the fix.Verification
As far as it can go before a real upload:
cargo publish --dry-run -p vgi-core— packages and compiles clean ✅cargo publish --dry-run -p verify-trust— now fails only with:publish.ymlhandles by publishingvgi-corefirst. No longer the stale-API error it gave at 0.4.7 — that's the signal the bump does what it needs to.cargo fmt --all --check,cargo check --workspace,cargo clippy --workspace --all-targets -- -D warnings,cargo test --workspace(136 pass),cargo +1.95.0 check --workspace— all clean.What tagging this unblocks
This is step 3 of the chain OpenVTC's manifest documents:
trql-client— done (0.17.0)publish.ymlfires → OpenVTC deletes its[patch.crates-io]blockOpenVTC currently consumes
did-git-signandvgi-corethrough git revs pinned to VGImain, which have to be re-pinned on everyvta-sdkminor. A published 0.4.8 lets that block go away and the requirement be floored at a real release.After merge
Tag
v0.4.8to firepublish.yml, which publishes all three in dependency order via crates.io Trusted Publishing. Left for a human to push — crates.io uploads can't be undone, only yanked.Still outstanding and not addressed here: OpenVTC is on
vta-sdk0.34.1 / TDK 0.12 while this workspace leads on 0.35.