Skip to content

Use regex for description tests with non-deterministic ordering #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyle-Ye merged 1 commit into from
Apr 15, 2026
Merged

Use regex for description tests with non-deterministic ordering #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 32 additions & 37 deletions Tests/OpenGesturesCompatibilityTests/Core/GestureTraitCompatibilityTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,23 +23,24 @@ struct GestureTraitCompatibilityTests {
// MARK: - Description

@Test(arguments: [
(GestureTrait.pan(), "pan"),
(GestureTrait.tap(), "tap"),
(GestureTrait.longPress(), "longPress"),
(GestureTrait.tap(tapCount: 1), "tap {tapCount: 1}"),
(GestureTrait.tap(pointCount: 2), "tap {pointCount: 2}"),
(GestureTrait.longPress(maximumMovement: 10.0), "longPress {maximumMovement: 10.0}"),
])
func description(_ trait: GestureTrait, _ expectedDescription: String) {
#expect("\(trait)" == expectedDescription)
}

@Test
func descriptionMultipleAttributes() {
let trait = GestureTrait.tap(tapCount: 1, pointCount: 3)
(GestureTrait.pan(), "pan", nil),
(GestureTrait.tap(), "tap", nil),
(GestureTrait.longPress(), "longPress", nil),
(GestureTrait.tap(tapCount: 1), "tap {tapCount: 1}", nil),
(GestureTrait.tap(pointCount: 2), "tap {pointCount: 2}", nil),
(GestureTrait.longPress(maximumMovement: 10.0), "longPress {maximumMovement: 10.0}", nil),
// Dictionary ordering of attributes is non-deterministic, so accept either order.
(GestureTrait.tap(tapCount: 1, pointCount: 3), nil, #/tap \{(?:tapCount: 1, pointCount: 3|pointCount: 3, tapCount: 1)\}/#),
] as [(GestureTrait, String?, Regex<Substring>?)])
func description(_ trait: GestureTrait, _ expected: String?, _ expectedRegex: Regex<Substring>?) throws {
let description = "\(trait)"
// Dictionary ordering of attributes is non-deterministic
#expect(description == "tap {tapCount: 1, pointCount: 3}" || description == "tap {pointCount: 3, tapCount: 1}")
if let expectedRegex {
_ = try #require(description.wholeMatch(of: expectedRegex))
} else if let expected {
#expect(description == expected)
} else {
Issue.record("neither expected nor expectedRegex is set")
}
}

// MARK: - GestureTrait Factory Methods
Expand Down Expand Up @@ -178,27 +179,21 @@ struct GestureTraitCollectionCompatibilityTests {
}

@Test(arguments: [
(GestureTraitCollection.withTrait(.pan()), "[pan]"),
(GestureTraitCollection.withTrait(.tap(tapCount: 1)), "[tap {tapCount: 1}]"),
])
func description(_ collection: GestureTraitCollection, _ expectedDescription: String) {
#expect("\(collection)" == expectedDescription)
}

@Test
func descriptionMultipleAttributes() {
let collection = GestureTraitCollection.withTrait(.tap(tapCount: 1, pointCount: 3))
(GestureTraitCollection.withTrait(.pan()), "[pan]", nil),
(GestureTraitCollection.withTrait(.tap(tapCount: 1)), "[tap {tapCount: 1}]", nil),
// Dictionary ordering of attributes is non-deterministic, so accept either order.
(GestureTraitCollection.withTrait(.tap(tapCount: 1, pointCount: 3)), nil, #/\[tap \{(?:tapCount: 1, pointCount: 3|pointCount: 3, tapCount: 1)\}\]/#),
// Dictionary ordering of traits is non-deterministic, so accept either order.
(GestureTraitCollection(traits: [.pan(), .tap()]), nil, #/\[(?:tap, pan|pan, tap)\]/#),
] as [(GestureTraitCollection, String?, Regex<Substring>?)])
func description(_ collection: GestureTraitCollection, _ expected: String?, _ expectedRegex: Regex<Substring>?) throws {
let description = "\(collection)"
// Dictionary ordering of attributes is non-deterministic
#expect(description == "[tap {tapCount: 1, pointCount: 3}]" || description == "[tap {pointCount: 3, tapCount: 1}]")

}

@Test
func descriptionMultipleTraits() {
let collection = GestureTraitCollection(traits: [.pan(), .tap()])
let description = "\(collection)"
// Dictionary ordering of traits is non-deterministic
#expect(description == "[tap, pan]" || description == "[pan, tap]")
if let expectedRegex {
_ = try #require(description.wholeMatch(of: expectedRegex))
} else if let expected {
#expect(description == expected)
} else {
Issue.record("neither expected nor expectedRegex is set")
}
}
}
Loading