Use regex for description tests with non-deterministic ordering#12
Merged
Conversation
Attribute dictionaries don't guarantee key order, so the description tests previously matched both permutations via `||`-chained equality and lived in separate `descriptionMultipleAttributes` / `descriptionMultipleTraits` methods. Merge those cases into the parameterized `description` tests with a (String?, Regex<Substring>?) argument pair: deterministic cases still use fast `==`, and only the non-deterministic cases pay for `wholeMatch(of:)`.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
- Coverage 71.85% 71.65% -0.20%
==========================================
Files 56 56
Lines 1439 1436 -3
==========================================
- Hits 1034 1029 -5
- Misses 405 407 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
descriptionMultipleAttributes/descriptionMultipleTraitsinto the parameterizeddescriptiontests inGestureTraitCompatibilityTestsandGestureTraitCollectionCompatibilityTests.#expect(a == "X" || a == "Y")pattern used for non-deterministic dictionary ordering. Use a(String?, Regex<Substring>?)argument pair so deterministic cases still assert via fast==and only the order-sensitive cases pay forwholeMatch(of:)withtry #require.Test plan
OPENGESTURES_COMPATIBILITY_TEST=0 swift test --filter 'GestureTraitCompatibilityTests.description|GestureTraitCollectionCompatibilityTests.description'— all 11 parameter rows pass (7 trait + 4 collection).