Skip to content

fix: complete lifecycleInit Future on Android #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nan-li merged 1 commit into from
Dec 11, 2025
Merged

fix: complete lifecycleInit Future on Android #1095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions android/src/main/java/com/onesignal/flutter/OneSignalInAppMessages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ else if (call.method.contentEquals("OneSignal#arePaused"))
else if (call.method.contentEquals("OneSignal#paused"))
this.paused(call, result);
else if (call.method.contentEquals("OneSignal#lifecycleInit"))
this.lifecycleInit();
this.lifecycleInit(result);
else
replyNotImplemented(result);
}
Expand Down Expand Up @@ -90,9 +90,10 @@ private void paused(MethodCall call, Result result) {
replySuccess(result, null);
}

public void lifecycleInit() {
public void lifecycleInit(Result result) {
OneSignal.getInAppMessages().addLifecycleListener(this);
OneSignal.getInAppMessages().addClickListener(this);
replySuccess(result, null);
}

@Override
Expand Down
5 changes: 3 additions & 2 deletions android/src/main/java/com/onesignal/flutter/OneSignalNotifications.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ else if (call.method.contentEquals("OneSignal#displayNotification"))
else if (call.method.contentEquals("OneSignal#preventDefault"))
this.preventDefault(call, result);
else if (call.method.contentEquals("OneSignal#lifecycleInit"))
this.lifecycleInit();
this.lifecycleInit(result);
else if (call.method.contentEquals("OneSignal#proceedWithWillDisplay"))
this.proceedWithWillDisplay(call, result);
else if (call.method.contentEquals("OneSignal#addNativeClickListener"))
Expand Down Expand Up @@ -210,9 +210,10 @@ public void onNotificationPermissionChange(boolean permission) {
invokeMethodOnUiThread("OneSignal#onNotificationPermissionDidChange", hash);
}

private void lifecycleInit() {
private void lifecycleInit(Result result) {
OneSignal.getNotifications().addForegroundLifecycleListener(this);
OneSignal.getNotifications().addPermissionObserver(this);
replySuccess(result, null);
}

private void registerClickListener() {
Expand Down
5 changes: 3 additions & 2 deletions android/src/main/java/com/onesignal/flutter/OneSignalPushSubscription.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ else if (call.method.contentEquals("OneSignal#pushSubscriptionToken"))
else if (call.method.contentEquals("OneSignal#pushSubscriptionOptedIn"))
replySuccess(result, OneSignal.getUser().getPushSubscription().getOptedIn());
else if (call.method.contentEquals("OneSignal#lifecycleInit"))
this.lifecycleInit();
this.lifecycleInit(result);
else
replyNotImplemented(result);
}
Expand All @@ -50,8 +50,9 @@ private void optOut(MethodCall call, Result reply) {
replySuccess(reply, null);
}

private void lifecycleInit() {
private void lifecycleInit(Result result) {
OneSignal.getUser().getPushSubscription().addObserver(this);
replySuccess(result, null);
}

@Override
Expand Down
5 changes: 3 additions & 2 deletions android/src/main/java/com/onesignal/flutter/OneSignalUser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ else if (call.method.contentEquals("OneSignal#removeTags"))
else if (call.method.contentEquals("OneSignal#getTags"))
this.getTags(call, result);
else if (call.method.contentEquals("OneSignal#lifecycleInit"))
this.lifecycleInit();
this.lifecycleInit(result);
else
replyNotImplemented(result);
}
Expand All @@ -67,8 +67,9 @@ private void setLanguage(MethodCall call, Result result) {
replySuccess(result, null);
}

private void lifecycleInit() {
private void lifecycleInit(Result result) {
OneSignal.getUser().addObserver(this);
replySuccess(result, null);
}

private void getOnesignalId(MethodCall call, Result result) {
Expand Down