Skip to content

Conversation

@nan-li
Copy link
Contributor

@nan-li nan-li commented Dec 8, 2025

Description

One Line Summary

Fix Android lifecycleInit() Future not completing, causing await to hang indefinitely.

Details

Motivation

  • Addresses [Bug]:On Android lifecycleInit() never complete a Future. #937
  • The lifecycleInit() methods in Android were not completing their Futures, which can cause await calls to hang indefinitely. This fix adds the Result parameter and calls replySuccess() to properly complete the Future, matching the iOS implementation.

Scope

Not a public method but update for consistency and future proofing

Testing

Manual testing

Android emulator on API 35

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

The lifecycleInit() methods in Android were not completing their Futures, which can cause await calls to hang indefinitely. This fix adds the Result parameter and calls replySuccess() to properly complete the Future, matching the iOS implementation.
@nan-li nan-li requested a review from a team as a code owner December 8, 2025 19:07
@nan-li nan-li merged commit 9d11713 into main Dec 11, 2025
5 checks passed
@nan-li nan-li deleted the fix/complete_lifecycleInit branch December 11, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants