Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added the responsiveness to the header #62

Merged
merged 6 commits into from
Oct 27, 2024
Merged

feat: added the responsiveness to the header #62

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c4a4263
feat: added the responsiveness to the header
tarunsinghofficial Oct 22, 2024
269baa6
lint: fixed linting issues
tarunsinghofficial Oct 22, 2024
97c1793
refactor: fixes previous header commits with new
tarunsinghofficial Oct 23, 2024
236e6d8
lint: linting done
tarunsinghofficial Oct 23, 2024
0f0415c
Merge remote-tracking branch 'upstream/main' into header-ui
tarunsinghofficial Oct 27, 2024
c04bee1
refactor: moved mobile responsive code to MobileMenu.svelte component
tarunsinghofficial Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 93 additions & 18 deletions src/components/navigation/Header.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,38 +6,113 @@
} from '$env/static/public';

import ThemeSwitcher from '$lib/ThemeSwitch/ThemeSwitcher.svelte';
import { fly } from 'svelte/transition';

let isMobileMenuOpen = false;

let headerLinks = null;

if (PUBLIC_NAV_BAR_LINKS) {
headerLinks = JSON.parse(PUBLIC_NAV_BAR_LINKS);
}

function toggleNavbar() {
isMobileMenuOpen = !isMobileMenuOpen;
}
</script>

<div
class="bg-blur-md flex items-center justify-between border-b border-gray-500 bg-white/80 px-4 dark:bg-black dark:text-white"
class="bg-blur-md flex items-center justify-between border-b border-gray-500 bg-white/80 px-4 dark:bg-black dark:text-white md:flex-row md:px-8"
>
<div class="flex items-center justify-center gap-4 px-2 py-2">
<div class="flex items-center justify-center gap-x-2">
<a href="/" class="block">
<img src={PUBLIC_OBA_LOGO_URL} alt={PUBLIC_OBA_REGION_NAME} class="h-10 rounded-sm" />
</a>
<a href="/" class="block text-xl font-extrabold">
{PUBLIC_OBA_REGION_NAME}
</a>
</div>
<div class="flex flex-1 items-center justify-between md:flex-none">
<div class="flex w-full justify-between gap-4 px-2 py-2 md:w-auto">
<div class="flex items-center justify-center gap-x-2">
<a href="/" class="block">
<img src={PUBLIC_OBA_LOGO_URL} alt={PUBLIC_OBA_REGION_NAME} class="h-10 rounded-sm" />
</a>
<a href="/" class="block text-xl font-extrabold">
{PUBLIC_OBA_REGION_NAME}
</a>
</div>

<div class="flex gap-x-4">
{#each Object.entries(headerLinks) as [key, value]}
<div class="rounded-md border bg-white/80 dark:bg-gray-800">
<a href={value} class="block px-2 py-1 font-semibold text-gray-900 dark:text-white"
>{key}</a
<div class="flex items-center justify-end md:hidden">
<button on:click={toggleNavbar}>
<svg
class="burger-icon h-6 w-6 text-gray-900 dark:text-white"
fill="none"
stroke="currentColor"
viewBox="0 0 24 24"
xmlns="http://www.w3.org/2000/svg"
>
</div>
{/each}
<path
stroke-linecap="round"
stroke-linejoin="round"
stroke-width="2"
d="M4 6h16M4 12h16m-7 6h7"
></path>
</svg>
</button>
</div>
</div>

<div class="hidden items-center gap-4 px-2 py-2 md:flex">
<div class="flex gap-x-4">
{#each Object.entries(headerLinks) as [key, value]}
<div class="rounded-md border bg-white/80 dark:bg-gray-800">
<a href={value} class="block px-2 py-1 font-semibold text-gray-900 dark:text-white"
>{key}</a
>
</div>
{/each}
</div>
</div>
</div>
<div>

<div class="hidden md:flex">
<ThemeSwitcher />
</div>
</div>

{#if isMobileMenuOpen}
<div
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should all be extracted into a new MobileMenu component.

class="fixed inset-0 z-50 flex flex-col items-center justify-center space-y-6 bg-white p-4 dark:bg-black md:hidden"
transition:fly={{ x: 1000, duration: 300 }}
>
<button on:click={toggleNavbar}>
<svg
class="close-icon h-6 w-6 text-gray-900 dark:text-white"
fill="none"
stroke="currentColor"
viewBox="0 0 24 24"
xmlns="http://www.w3.org/2000/svg"
>
<path
stroke-linecap="round"
stroke-linejoin="round"
stroke-width="2"
d="M6 18L18 6M6 6l12 12"
></path>
</svg>
</button>

<div class="flex flex-col items-center gap-4">
{#each Object.entries(headerLinks) as [key, value]}
<a
href={value}
class="block text-xl font-semibold text-gray-900 dark:text-white"
on:click={toggleNavbar}>{key}</a
>
{/each}
</div>
<div>
<ThemeSwitcher />
</div>
</div>
{/if}

<style lang="postcss">
.burger-icon,
.close-icon {
cursor: pointer;
}
</style>
Loading