Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added the responsiveness to the header #62

Merged
merged 6 commits into from
Oct 27, 2024

Conversation

tarunsinghofficial
Copy link
Collaborator

Issue:
Currently, the header is not responsive, and users aren't able to use the header on small screens like mobiles, etc.

Fixes: #6
Added the responsiveness to the header/navbar.

Screenshot:
image
image

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! please rebase off of the latest commits in main

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please extract the mobile menu into a new component and I think it'll be ready to merge.

<ThemeSwitcher />
</div>
</div>

{#if isMobileMenuOpen}
<div
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should all be extracted into a new MobileMenu component.

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@aaronbrethorst aaronbrethorst merged commit e43f22b into OneBusAway:main Oct 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants