-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added the responsiveness to the header #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! please rebase off of the latest commits in main
f116e9e
to
269baa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please extract the mobile menu into a new component and I think it'll be ready to merge.
<ThemeSwitcher /> | ||
</div> | ||
</div> | ||
|
||
{#if isMobileMenuOpen} | ||
<div |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should all be extracted into a new MobileMenu component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks!
Issue:
Currently, the header is not responsive, and users aren't able to use the header on small screens like mobiles, etc.
Fixes: #6
Added the responsiveness to the header/navbar.
Screenshot: