Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] stock_available_to_promise_release: normal outgoing moves are mergeable #937

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

lmignon
Copy link
Contributor

@lmignon lmignon commented Oct 14, 2024

outgoing moves from unreleasable pickings are mergeable by default. This fix is required to avoid to disalbe the merge of moves from outgoing picking when the module is installed but the associated stock.rule is not configured to defer the pull of not available qty

ping @jbaudoux

@lmignon lmignon changed the title [FIX] stock_available_to_promise_release: normal outgoing are mergeable [FIX] stock_available_to_promise_release: normal outgoing moves are mergeable Oct 14, 2024
@lmignon lmignon force-pushed the 16.0-stock_available_to_promise_release-fix_merge_moves branch from 78cc28f to 4f5fdef Compare October 14, 2024 15:05
@lmignon lmignon changed the title [FIX] stock_available_to_promise_release: normal outgoing moves are mergeable [16.0][FIX] stock_available_to_promise_release: normal outgoing moves are mergeable Oct 14, 2024
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, shouldn't user_is_allowed = self.env.user.has_group("stock.group_stock_user") move to unrelease_allowed instead of _is_unreleasable() ?

stock_available_to_promise_release/models/stock_move.py Outdated Show resolved Hide resolved
@lmignon
Copy link
Contributor Author

lmignon commented Oct 15, 2024

By the way, shouldn't user_is_allowed = self.env.user.has_group("stock.group_stock_user") move to unrelease_allowed instead of _is_unreleasable() ?

I share the same felling. I change the code.

@lmignon lmignon force-pushed the 16.0-stock_available_to_promise_release-fix_merge_moves branch from 4f5fdef to 830f5ea Compare October 15, 2024 07:09
@lmignon
Copy link
Contributor Author

lmignon commented Oct 15, 2024

@jbaudoux changes done

@lmignon lmignon force-pushed the 16.0-stock_available_to_promise_release-fix_merge_moves branch from 830f5ea to 19a8041 Compare October 15, 2024 07:11
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :)

@rousseldenis rousseldenis added the enhancement New feature or request label Oct 17, 2024
@rousseldenis rousseldenis added this to the 16.0 milestone Oct 17, 2024
…ergeable

outgoing moves from unreleasable pickings are mergeable by default. This fix is required to avoid to disalbe the merge of moves from outgoing picking when the module is installed but the associated stock.rule is not configured to defer the pull of not available qty
@lmignon lmignon force-pushed the 16.0-stock_available_to_promise_release-fix_merge_moves branch from 19a8041 to 66693a8 Compare October 17, 2024 13:23
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants