Skip to content

Commit

Permalink
[FIX] stock_available_to_promise_release: normal outgoing moves are m…
Browse files Browse the repository at this point in the history
…ergeable

outgoing moves from unreleasable pickings are mergeable by default. This fix is required to avoid to disalbe the merge of moves from outgoing picking when the module is installed but the associated stock.rule is not configured to defer the pull of not available qty
  • Loading branch information
lmignon committed Oct 14, 2024
1 parent 98b705a commit 4f5fdef
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
4 changes: 3 additions & 1 deletion stock_available_to_promise_release/models/stock_move.py
Original file line number Diff line number Diff line change
Expand Up @@ -787,7 +787,9 @@ def write(self, vals):
def _is_mergeable(self):
self.ensure_one()
return self.state not in ("done", "cancel") and (
self.picking_type_id.code != "outgoing" or self.unrelease_allowed
self.picking_type_id.code != "outgoing"
or not self._is_unreleaseable()
or self.unrelease_allowed
)

def _update_candidate_moves_list(self, candidate_moves):
Expand Down
12 changes: 12 additions & 0 deletions stock_available_to_promise_release/tests/test_merge_moves.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,3 +136,15 @@ def test_unrelease_at_move_merge_merged(self):
self.assertEqual(1, len(move))
self.assertEqual(2 + original_qty_1 + original_qty_2, move.product_uom_qty)
self.assertEqual(2, move.move_line_ids.qty_done)

def test_default_merge(self):
# check that the merge is still working when the available_to_promise_defer_pull
# is False
self.wh.delivery_route_id.write(
{
"available_to_promise_defer_pull": False,
}
)
# run a new procurement for the same product in the shipment 1
self._procure(2)
self.assertEqual(1, len(self.shipping1.move_ids))

0 comments on commit 4f5fdef

Please sign in to comment.