Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] tracking_manager: add domain condition for tracking fields #3176

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

CRogos
Copy link
Contributor

@CRogos CRogos commented Jan 24, 2025

I would like to extend the functionality of tracking_manager by adding the possibility to enable tracking only on certain condition, by adding a tracking_domain field. The value is only tracked if the filter applies.

image

image

image

@OCA-git-bot
Copy link
Contributor

Hi @sebastienbeau, @Kev-Roche,
some modules you are maintaining are being modified, check this out!

@fb-ife
Copy link

fb-ife commented Jan 31, 2025

@CRogos ,
can you please provide me with configuration'steps to test the functionality?

Thanks

@CRogos
Copy link
Contributor Author

CRogos commented Jan 31, 2025

@fb-ife have you had a look into the screenshots above and the usage documentation file? I've already highlighted the configuration steps. Not sure what else needs to be added?

@CRogos CRogos force-pushed the 17.0-tracking_manager-domain branch from d7dfa81 to b94e4a1 Compare February 17, 2025 10:25
@CRogos
Copy link
Contributor Author

CRogos commented Feb 24, 2025

@sebastienbeau, @Kev-Roche I would really like to add this improvement to this module. Could you have a look at this?
thank you in advance.

Copy link

@MohamedOsman7 MohamedOsman7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the runboat. Functional & code review LGTM

@CRogos
Copy link
Contributor Author

CRogos commented Mar 4, 2025

@pedrobaeza what do you think about this change? I would be very pleased if you could do the second review and merge if it is OK.

@pedrobaeza pedrobaeza added this to the 17.0 milestone Mar 4, 2025
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem I see with this change is that affects performance even if you don't define any domain, so I'm not totally liking. You may do this in a extra module?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why changing the file name and putting drawio ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This picture is an valid png file, but also an valid draw.io file.
When you have the draw.io extension installed in vscode, you can edit the rectangles of the picture. That means you always have the unchanged screenshot and can add or remove additional highlighting easily.

image

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, didn't know. Thanks for telling me.

@CRogos CRogos force-pushed the 17.0-tracking_manager-domain branch 2 times, most recently from acded75 to 36c0a1b Compare March 4, 2025 17:55
@CRogos CRogos force-pushed the 17.0-tracking_manager-domain branch from 36c0a1b to 878aa2b Compare March 4, 2025 17:56
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm, I'm not sure that this code fixes the performance thing and even if _mail_track is the correct hook. I still prefer to have that as a separate module, but let's see what others think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants