-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][IMP] tracking_manager: add domain condition for tracking fields #3176
base: 17.0
Are you sure you want to change the base?
Conversation
Hi @sebastienbeau, @Kev-Roche, |
1baa1e4
to
d7dfa81
Compare
@CRogos , Thanks |
@fb-ife have you had a look into the screenshots above and the usage documentation file? I've already highlighted the configuration steps. Not sure what else needs to be added? |
d7dfa81
to
b94e4a1
Compare
@sebastienbeau, @Kev-Roche I would really like to add this improvement to this module. Could you have a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with the runboat. Functional & code review LGTM
@pedrobaeza what do you think about this change? I would be very pleased if you could do the second review and merge if it is OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem I see with this change is that affects performance even if you don't define any domain, so I'm not totally liking. You may do this in a extra module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why changing the file name and putting drawio
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, didn't know. Thanks for telling me.
acded75
to
36c0a1b
Compare
36c0a1b
to
878aa2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhm, I'm not sure that this code fixes the performance thing and even if _mail_track
is the correct hook. I still prefer to have that as a separate module, but let's see what others think.
I would like to extend the functionality of tracking_manager by adding the possibility to enable tracking only on certain condition, by adding a tracking_domain field. The value is only tracked if the filter applies.