Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] tracking_manager: add field type html support #3175

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

CRogos
Copy link
Contributor

@CRogos CRogos commented Jan 24, 2025

tracking_manager enables the user to activate tracking on html fields. This leads to an error message:
image

@OCA-git-bot
Copy link
Contributor

Hi @sebastienbeau, @Kev-Roche,
some modules you are maintaining are being modified, check this out!

Copy link

@MohamedOsman7 MohamedOsman7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@fb-ife fb-ife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CRogos I think you need to update the readme file by incresing the version and add the history of your changes

@CRogos
Copy link
Contributor Author

CRogos commented Jan 31, 2025

@fb-ife regarding the version change I am 100% sure that this is automatically changed by the bot/ci.

Adding some description to a history is also new to my. Aren't the git commits the history? If you are think I am wrong I need a little bit more guidance where to change.
I could have add me to the contributor list, but I am doing this already on this PR #3176

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants