Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][IMP] partner_manual_rank: Set default value based on res_partner_search_mode context #1535

Merged
merged 1 commit into from
Aug 23, 2023
Merged

[15.0][IMP] partner_manual_rank: Set default value based on res_partner_search_mode context #1535

merged 1 commit into from
Aug 23, 2023

Conversation

amarcosg
Copy link
Contributor

@amarcosg amarcosg commented Jun 6, 2023 •
edited by rafaelbn
Loading

@OCA-git-bot
Copy link
Contributor

Hi @frahikLV, @luisg123v,
some modules you are maintaining are being modified, check this out!

@luisg123v
Copy link

Let's wayt for #1533 to be merged first, as that one has comments.

@amarcosg amarcosg force-pushed the 15.0-imp-partner_manual_rank-default-values branch from b0a1c0d to 23191d9 Compare June 7, 2023 08:26
@rafaelbn rafaelbn added this to the 15.0 milestone Aug 11, 2023
@rafaelbn
Copy link
Member

Travis 🔴 , previous PR 🔴 waiting to fix the first one and have all 🍏

@rafaelbn rafaelbn mentioned this pull request Aug 11, 2023
Merged
2 tasks
ypapouin
ypapouin approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@ypapouin ypapouin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

@luisg123v
Copy link

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@luisg123v The rebase process failed, because command git push --force factorlibre tmp-pr-1535:15.0-imp-partner_manual_rank-default-values failed with output:

remote: Permission to factorlibre/partner-contact.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/factorlibre/partner-contact/': The requested URL returned error: 403

@luisg123v
Copy link

/ocabot merge patch

It will be rebased anyway when merging.

@ypapouin @amarcosg
[IMP] partner_manual_rank: Set default value based on `res_partner_se…
713b435 
…arch_mode` context

Use context set by Odoo in most of their views to pre-fill supplier/customer fields.
@amarcosg amarcosg force-pushed the 15.0-imp-partner_manual_rank-default-values branch from 23191d9 to 713b435 Compare August 23, 2023 15:39
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1535-by-luisg123v-bump-patch, awaiting test results.

@luisg123v luisg123v mentioned this pull request Aug 23, 2023
Merged
@OCA-git-bot OCA-git-bot merged commit 6d14ba5 into OCA:15.0 Aug 23, 2023
5 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a4136ac. Thanks a lot for contributing to OCA. ❤️

@amarcosg amarcosg deleted the 15.0-imp-partner_manual_rank-default-values branch August 23, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypapouin ypapouin ypapouin approved these changes

@luisg123v luisg123v luisg123v approved these changes

@MiquelRForgeFlow MiquelRForgeFlow Awaiting requested review from MiquelRForgeFlow

Assignees
No one assigned
Labels
approved merged 🎉 work in progress
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@amarcosg @OCA-git-bot @luisg123v @rafaelbn @ypapouin