Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] partner_manual_rank: Set default value based on res_partner_search_mode context #1534

Merged
merged 1 commit into from
Aug 23, 2023
Merged

[16.0][IMP] partner_manual_rank: Set default value based on res_partner_search_mode context #1534

merged 1 commit into from
Aug 23, 2023

Conversation

amarcosg
Copy link
Contributor

@amarcosg amarcosg commented Jun 6, 2023 •
edited by rafaelbn
Loading

@OCA-git-bot
Copy link
Contributor

Hi @frahikLV, @luisg123v,
some modules you are maintaining are being modified, check this out!

@luisg123v
Copy link

Let's wait for #1533 first to be merged, as that one has comments.

@amarcosg amarcosg force-pushed the 16.0-imp-partner_manual_rank-default-values branch from 510ae48 to dd4d730 Compare June 7, 2023 08:31
@rafaelbn rafaelbn added this to the 16.0 milestone Aug 11, 2023
@rafaelbn
Copy link
Member

Thank you! please review previous PR first! Thank you! ❤️

MiquelRForgeFlow
MiquelRForgeFlow approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a rebase is needed to greenify runboat.

@ypapouin @amarcosg
[IMP] partner_manual_rank: Set default value based on `res_partner_se…
b6dd6f5 
…arch_mode` context

Use context set by Odoo in most of their views to pre-fill supplier/customer fields.
@amarcosg amarcosg force-pushed the 16.0-imp-partner_manual_rank-default-values branch from dd4d730 to b6dd6f5 Compare August 23, 2023 15:33
luisg123v
luisg123v approved these changes Aug 23, 2023
View reviewed changes
Copy link

@luisg123v luisg123v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@luisg123v The rebase process failed, because command git push --force factorlibre tmp-pr-1534:16.0-imp-partner_manual_rank-default-values failed with output:

remote: Permission to factorlibre/partner-contact.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/factorlibre/partner-contact/': The requested URL returned error: 403

@luisg123v
Copy link

/ocabot merge patch

It will be rebased anyway when merging.

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1534-by-luisg123v-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 19111ad into OCA:16.0 Aug 23, 2023
7 of 8 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fc4a871. Thanks a lot for contributing to OCA. ❤️

@luisg123v luisg123v mentioned this pull request Aug 23, 2023
Merged
@amarcosg amarcosg deleted the 16.0-imp-partner_manual_rank-default-values branch August 23, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@ypapouin ypapouin ypapouin approved these changes

@luisg123v luisg123v luisg123v approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 work in progress
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@amarcosg @OCA-git-bot @luisg123v @rafaelbn @ypapouin @MiquelRForgeFlow