Skip to content

[CI] Move also GPU tests to Julia v1.13 #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giordano merged 7 commits into from
Sep 27, 2026
Merged

[CI] Move also GPU tests to Julia v1.13 #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d7c193c
[CI] Move also GPU tests to Julia v1.13
giordano Sep 26, 2026
03f999b
[test] Force release of more memory when compiling new topologies wit…
giordano Sep 26, 2026
168716e
Skip Aqua's persistent tasks check on Windows
giordano Sep 26, 2026
4b691ca
DROP ME: Check out dev branch of Reactant
giordano Sep 26, 2026
4b4232a
Update Project.toml
giordano Sep 27, 2026
5dddc66
Revert "Skip Aqua's persistent tasks check on Windows"
giordano Sep 27, 2026
e0385c5
Remove call to malloc_trim
giordano Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
include:
# `--check-bounds=auto` is necessary for testing Reactant workloads
# until https://github.com/EnzymeAD/Reactant.jl/issues/2347 is fixed.
- version: "1.12.6"
- version: "1.13.0"
os: aws-linux-nvidia-gpu-l4-4xl
arch: "default"
check-bounds: "auto"
Expand Down
3 changes: 3 additions & 0 deletions test/reactant/weno_compilation_setup.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ function run_weno_tests(scheme_label, scheme)
Δt = 0.02

@testset "$label" for (label, topo, nd) in topologies
# Force release of memory
GC.gc(true); GC.gc(false); GC.gc(true)
Comment on lines +97 to +98

@giordano giordano Sep 27, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Reactant v0.2.289, memory leaks in their compilation pipeline are resolved, and we shouldn't crash here anymore (waiting for new run to be sure). These GC.gc calls aren't strictly needed (they weren't solving our problem earlier because it was due to memory leaks in Reactant, not tracked by the garbage collector), but keeping them doesn't hurt and should help reducing memory pressure a tiny little bit.

I'm still pushing to further reduce memory usage with EnzymeAD/Reactant.jl#3345


grid = make_grid(topo, nd)

# ── Build ──
Expand Down
Loading