[CI] Move also GPU tests to Julia v1.13 - #1033
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
giordano
marked this pull request as draft
September 26, 2026 16:53
Member
Author
|
This depends on the EnzymeAD/Reactant.jl#3341 stack |
giordano
marked this pull request as ready for review
September 27, 2026 10:50
giordano
commented
Sep 27, 2026
Comment on lines
+97
to
+98
| # Force release of memory | ||
| GC.gc(true); GC.gc(false); GC.gc(true) |
Member
Author
There was a problem hiding this comment.
With Reactant v0.2.289, memory leaks in their compilation pipeline are resolved, and we shouldn't crash here anymore (waiting for new run to be sure). These GC.gc calls aren't strictly needed (they weren't solving our problem earlier because it was due to memory leaks in Reactant, not tracked by the garbage collector), but keeping them doesn't hurt and should help reducing memory pressure a tiny little bit.
I'm still pushing to further reduce memory usage with EnzymeAD/Reactant.jl#3345
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1032