Skip to content

Find package wrapper#375

Merged
zachcran merged 5 commits intomasterfrom
find_package_wrapper
Feb 2, 2026
Merged

Find package wrapper#375
zachcran merged 5 commits intomasterfrom
find_package_wrapper

Conversation

@zachcran
Copy link
Copy Markdown
Contributor

@zachcran zachcran commented Dec 1, 2025

Description

This PR utilizes the find_package wrappers added by NWChemEx/NWXCMake#59.

TODOs

  • Verify that it works when built independently
  • Verify that it works when built in Spack

NOTE

Original PR description below, when the wrappers were implemented here.


(Moved to NWChemEx/NWXCMake#59)

Is this pull request associated with an issue(s)?

None that I could find.

Description

This adds wrapper functions to CMake's find_package() that add a wrapper target in CMaize. This allows them to be added properly as dependencies for the main project target and appear properly in the installed <package>Config.cmake and <target>-target.cmake files.

TODOs

  • Potentially rename the added functions to avoid implying that they are in the CMaize package (or migrate them to the CMaize package)
  • License header?
  • Validation of pairwise TARGETS argument to cmaize_find_package
  • Removed leftover commented-out code
  • Add function-level documentation

@zachcran zachcran self-assigned this Dec 1, 2025
@zachcran zachcran added the bug-fix Fixes a bug with a PR label Dec 1, 2025
@zachcran zachcran marked this pull request as ready for review January 28, 2026 19:00
@zachcran
Copy link
Copy Markdown
Contributor Author

Checks can't pass until NWChemEx/NWXCMake#59 is merged.

jwaldrop107
jwaldrop107 previously approved these changes Jan 28, 2026
Copy link
Copy Markdown
Member

@jwaldrop107 jwaldrop107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachcran
Copy link
Copy Markdown
Contributor Author

zachcran commented Feb 2, 2026

@jwaldrop107 @ryanmrichard All unit tests are passing now after the fix in NWChemEx/NWXCMake#60! This is ready for final approvals.

@zachcran zachcran enabled auto-merge February 2, 2026 18:58
@zachcran zachcran merged commit 63eda7c into master Feb 2, 2026
10 of 13 checks passed
@zachcran zachcran deleted the find_package_wrapper branch February 2, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix Fixes a bug with a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants