Skip to content

Add find_package wrapper#59

Merged
zachcran merged 5 commits intomasterfrom
find_package_wrapper
Jan 28, 2026
Merged

Add find_package wrapper#59
zachcran merged 5 commits intomasterfrom
find_package_wrapper

Conversation

@zachcran
Copy link
Copy Markdown
Contributor

@zachcran zachcran commented Dec 15, 2025

Is this pull request associated with an issue(s)?

Originally part of NWChemEx/PluginPlay#375.

Description

This adds wrapper functions to CMake's find_package() that add a wrapper target in CMaize (nwx_wrap_target() and nwx_find_package()). This allows them to be added properly as dependencies for the main project target and appear properly in the installed <package>Config.cmake and <target>-target.cmake files.

TODOs

  • Potentially rename the added functions to avoid implying that they are in the CMaize package (or migrate them to the CMaize package)
  • License header?
  • Validation of pairwise TARGETS argument to nwx_find_package
  • Removed leftover commented-out code
  • Add function-level documentation

…re challenging with current built-in methods
@zachcran zachcran marked this pull request as ready for review January 28, 2026 18:59
@zachcran zachcran enabled auto-merge (squash) January 28, 2026 19:00
Copy link
Copy Markdown
Member

@jwaldrop107 jwaldrop107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachcran zachcran merged commit d4f0649 into master Jan 28, 2026
1 check passed
@zachcran zachcran deleted the find_package_wrapper branch January 28, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix Fixes a bug with a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants