Repository navigation
fix: use the configured network interface for SGLang distributed initialization - #497
Merged
ishandhanani merged 1 commit intoSep 23, 2026
Conversation
cquil11
requested review from
alec-flowers,
csahithi,
ishandhanani and
nlevin-ui
as code owners
September 23, 2026 16:32
This was referenced Sep 23, 2026
cquil11
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the configured
network_interfacewhen resolving SGLang’s distributed-init leader address, for regular and sidecar launches. Previously these calls ignored the cluster setting and could select a default-route address unreachable by peer nodes.Applies when one SGLang worker spans multiple nodes, not merely when prefill and decode occupy separate nodes. Includes interface-selection tests.
Extracted from #433; independent of ATOM/AToMesh and the AMD stack. 331 focused tests pass. No E2E failure is attributed to this change and no new E2E run was launched.