Skip to content

feat: [AMD Support via SemiAnalysis][3/4] ATOM and AToMesh support - #433

Merged
ishandhanani merged 1 commit into
NVIDIA:mainfrom
SemiAnalysisAI:upstream/atom-atomesh
Sep 23, 2026
Merged

ishandhanani merged 1 commit into
NVIDIA:mainfrom
SemiAnalysisAI:upstream/atom-atomesh

Conversation

@cquil11

@cquil11 cquil11 commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Add native ROCm ATOM workers and the official AToMesh router for aggregate and prefill/decode deployments, using srt-slurm's existing endpoint allocation, Slurm launch, and health/lifecycle machinery.

  • Launch atom.entrypoints.openai_server with native CLI spelling, model identity, and role-aware Mooncake transfer configuration.
  • Launch atomesh with the ATOM backend, static worker topology, and worker readiness gating. Infera is not part of this layer.
  • Restrict managed ATOM logical endpoints to one Slurm node each; P/D deployments can use multiple nodes and endpoints.

Unrelated fixes were extracted into standalone PRs outside this stack: vLLM hybrid-DP routing #496 and SGLang interface selection #497.

Review the stack

The upstream PRs target NVIDIA main and are manually stacked, so later upstream diffs include preceding layers. The downstream fork PRs form an actual branch-based stack (main → #1 → #11 → #7 → #14); each fork PR's Files changed tab isolates its layer for easier review.

Merge in that order, then rebase the remaining layers. ATOM uses Mooncake, not MoRI; its stack position is review ordering, not an engine dependency. The core runtime does not require the observation layer, but the InferenceX launcher uses its srtctl wait command.

E2E validation is maintained only in the base PR: upstream #431 / fork #1.

@cquil11
cquil11 force-pushed the upstream/atom-atomesh branch 2 times, most recently from 6272aff to 21405ee Compare September 17, 2026 22:26
@cquil11 cquil11 changed the title [AMD Support][3/3] ATOM and AToMesh support [AMD Support][3/4] ATOM and AToMesh support Sep 17, 2026
@cquil11 cquil11 changed the title [AMD Support][3/4] ATOM and AToMesh support feat: [AMD Support][3/4] ATOM and AToMesh support Sep 17, 2026
@cquil11 cquil11 changed the title feat: [AMD Support][3/4] ATOM and AToMesh support feat: [AMD Support via SemiAnalysis][3/4] ATOM and AToMesh support Sep 17, 2026
@cquil11
cquil11 force-pushed the upstream/atom-atomesh branch 3 times, most recently from 0d40bff to ec41193 Compare September 18, 2026 21:36
@cquil11
cquil11 force-pushed the upstream/atom-atomesh branch from ec41193 to 0b1a1ed Compare September 22, 2026 18:13
@cquil11
cquil11 force-pushed the upstream/atom-atomesh branch 6 times, most recently from d9b060f to 7d4ba50 Compare September 23, 2026 16:24
@cquil11
cquil11 force-pushed the upstream/atom-atomesh branch from 81292b0 to 9b99604 Compare September 23, 2026 17:18
@ishandhanani
ishandhanani merged commit 1231ed4 into NVIDIA:main Sep 23, 2026
9 checks passed
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.61745% with 11 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@7f0d2f0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/srtctl/backends/atom.py 89.32% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #433   +/-   ##
=======================================
  Coverage        ?   82.19%           
=======================================
  Files           ?      141           
  Lines           ?    20828           
  Branches        ?        0           
=======================================
  Hits            ?    17119           
  Misses          ?     3709           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants