-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[None][doc] Add Qwen3-Next Guide (new) #8181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughAdds a new deployment guide documenting how to run Qwen3-Next on TensorRT LLM, including prerequisites, Docker build/run, server YAML configuration, trtllm-serve launch options, testing endpoint, troubleshooting, and benchmarking with a provided script scaffold. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as User
participant D as Docker/Container
participant S as TRT-LLM Server
participant M as Model Repo
U->>D: Build Docker image (TensorRT LLM)
U->>D: Run container with GPUs and volumes
U->>D: Provide YAML config (tp_size, ep_size, etc.)
D->>M: Download/prepare Qwen3-Next model (trust_remote_code?)
U->>S: Launch trtllm-serve with CLI options
Note right of S: max_batch_size, max_num_tokens, kv cache, cuda graph, MoE
U->>S: Send inference request (test endpoint)
S-->>U: Return response
alt Benchmarking
U->>S: Run bench.sh with concurrent requests
S-->>U: Emit latency/throughput metrics
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
docs/source/deployment-guide/quick-start-recipe-for-qwen3-next-on-trtllm.md (2)
24-30
: Add a language hint to the shell snippet.Please annotate this fenced block with a language (
bash
orshell
) so markdownlint passes and readers get syntax highlighting.Apply this diff:
-``` +```bash cd TensorRT-LLM - make -C docker release_build IMAGE_TAG=qwen3-next-local - make -C docker release_run IMAGE_NAME=tensorrt_llm IMAGE_TAG=qwen3-next-local LOCAL_USER=1--- `176-178`: **Annotate the sample response block as JSON.** Marking this fence as `json` keeps markdownlint happy and improves readability with highlighting. Apply this diff: ```diff -``` +```json {"id":"chatcmpl-64ac201c77bf46a7a3a4eca7759b1fd8","object":"chat.completion","created":1759022940,"model":"Qwen/Qwen3-Next-80B-A3B-Thinking","choices":[{"index":0,"message":{"role":"assistant","content":"Okay, the user is asking \"Where is New York?\" Hmm, this seems straightforward but I need to be careful. New York could mean different things—maybe they're confused about the city versus the state.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/source/deployment-guide/quick-start-recipe-for-qwen3-next-on-trtllm.md
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
docs/source/deployment-guide/quick-start-recipe-for-qwen3-next-on-trtllm.md
24-24: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
176-176: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
|
||
### Creating the TRT-LLM Server config | ||
|
||
We create a YAML configuration file `/tmp/config.yml` for the TensorRT LLM Server. Note that we should set kv_cache_reuse to false. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify the KV-cache reuse setting name.
The note references a kv_cache_reuse
flag that does not exist in the sample YAML; the actual key is kv_cache_config.enable_block_reuse
. This mismatch will confuse readers trying to align the prose with the config snippet. Please update the note so it cites the real field name.
Apply this diff:
-We create a YAML configuration file `/tmp/config.yml` for the TensorRT LLM Server. Note that we should set kv_cache_reuse to false.
+We create a YAML configuration file `/tmp/config.yml` for the TensorRT LLM Server. Note that we should set `kv_cache_config.enable_block_reuse` to `false`.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
We create a YAML configuration file `/tmp/config.yml` for the TensorRT LLM Server. Note that we should set kv_cache_reuse to false. | |
We create a YAML configuration file `/tmp/config.yml` for the TensorRT LLM Server. Note that we should set `kv_cache_config.enable_block_reuse` to `false`. |
🤖 Prompt for AI Agents
In docs/source/deployment-guide/quick-start-recipe-for-qwen3-next-on-trtllm.md
around line 34, the explanatory note incorrectly references a non-existent
kv_cache_reuse flag; update the prose to reference the actual YAML field
kv_cache_config.enable_block_reuse and indicate it should be set to false in the
config snippet so the text matches the sample configuration.
Signed-off-by: Faradawn Yang <[email protected]>
6bf8c92
to
ec8086a
Compare
Summary by CodeRabbit
Description
Add Qwen3-Next Usage Guide. This guide is functional.
Rebasing from the previous PR: #8007
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...
Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]
to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]
Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id
(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test
(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast
(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test
(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"
(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"
(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"
(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test
(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test
(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test
(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge
(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"
(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log
(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug
(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-list
parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.md
and the
scripts/test_to_stage_mapping.py
helper.kill
kill
Kill all running builds associated with pull request.
skip
skip --comment COMMENT
Skip testing for latest commit on pull request.
--comment "Reason for skipping build/test"
is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.