Skip to content

Conversation

faradawn
Copy link

@faradawn faradawn commented Sep 25, 2025

@coderabbitai summary

Description

Create a guide for Qwen3 Next usage. Related to this PR: #7892

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@faradawn faradawn requested a review from a team as a code owner September 25, 2025 23:50
Copy link
Contributor

coderabbitai bot commented Sep 25, 2025

📝 Walkthrough

Walkthrough

Adds a new documentation page detailing end-to-end deployment of Qwen3-Next-80B-A3B-Thinking on TensorRT-LLM, including prerequisites, Docker usage, server YAML configuration, CLI flags, health checks, chat testing, troubleshooting, and benchmarking script scaffold. No source code or API changes.

Changes

Cohort / File(s) Summary of Changes
Docs
docs/source/deployment-guide/quick-start-recipe-for-qwen3-next-on-trtllm.md
New deployment guide for running Qwen3 Next on TensorRT-LLM: prerequisites, Docker run, YAML server config, launch flags (tp/ep, kv cache, limits), cuda_graph/moe config notes, health and chat tests, troubleshooting, and benchmarking script scaffold.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description retains the placeholder AI summary marker without providing a properly formatted title and leaves the Test Coverage section blank, so it does not fully follow the repository’s description template or include all required information. Please add a concrete PR title using the ticket/type pattern or the @coderabbitai title directive and populate the Test Coverage section with relevant tests or explicitly mark it as N/A if no tests apply to ensure the description matches the required template.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The title accurately reflects the primary change by indicating the addition of a Qwen3 Next Quick Start Guide and is concise, clear, and fully related to the documentation update.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1eb6531 and b9bf8e0.

📒 Files selected for processing (1)
  • docs/source/deployment-guide/quick-start-recipe-for-qwen3-next-on-trtllm.md (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

  • docs/source/deployment-guide/quick-start-recipe-for-qwen3-next-on-trtllm.md

@faradawn faradawn changed the title Add Qwen3 next quick start guide [doc] Add Qwen3 Next Quick Start Guide Sep 25, 2025
@svc-trtllm-gh-bot svc-trtllm-gh-bot added the Community want to contribute PRs initiated from Community label Sep 26, 2025
@nv-guomingz nv-guomingz removed the Community want to contribute PRs initiated from Community label Sep 26, 2025
@svc-trtllm-gh-bot svc-trtllm-gh-bot added the Community want to contribute PRs initiated from Community label Sep 26, 2025
@faradawn
Copy link
Author

Tested the trtllm serve command on 4x H100 - success.

@faradawn
Copy link
Author

Hi @nv-guomingz @byshiue I have tested the serve command. Could you check and let me know of any issue?

Copy link
Collaborator

@laikhtewari laikhtewari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we should be protecting these deployment guides with CI testing to prevent new changes from accidentally breaking at least functionality here -- what do you think @juney-nvidia?

@faradawn
Copy link
Author

@byshiue @nv-guomingz I have signed off the commits and benchmarked on H100 and B200. Feel free to merge and let me know if there is any issue!

@faradawn
Copy link
Author

Hi @laikhtewari , @ncomly-nvidia the guide is ready and tested on H100 and B200. I have fixed @nv-guomingz 's issue of container v1.1.0rc6 not containing Qwen3.

@laikhtewari
Copy link
Collaborator

laikhtewari commented Sep 30, 2025

Looks like we don't support Blackwell, I'd suggest explicitly stating this in the deployment guide to avoid confusion

We also should note model support + feature combination status, maybe deployment guide isn't the right place to doc this though -- I'd suggest noting this info here: https://github.com/NVIDIA/TensorRT-LLM/blob/main/docs/source/models/supported-models.md

Also need CI test

@faradawn
Copy link
Author

  1. Added notes on Blackwell is yet supported.

  2. For model feature support matrix, I wrote "no" for all columns except CUDA graph. Can @nv-guomingz and @byshiue help check?

Reference: model huggingface: https://huggingface.co/Qwen/Qwen3-Next-80B-A3B-Thinking

@Funatiq
Copy link
Collaborator

Funatiq commented Oct 1, 2025

Hi @faradawn, could you please cherry-pick the test from #8111 or add me as a collaborator to your fork so I can push to this branch?

@faradawn
Copy link
Author

faradawn commented Oct 1, 2025

Hi @Funatiq I have updated the guide to match your CI tests. Also added you to this fork - feel free to make any adjustment!

@Funatiq Funatiq self-requested a review October 2, 2025 08:40
@Funatiq Funatiq changed the title [doc] Add Qwen3 Next Quick Start Guide [None][doc] Add Qwen3 Next Quick Start Guide Oct 2, 2025
@Funatiq Funatiq requested a review from a team as a code owner October 2, 2025 09:03
mikeiovine and others added 24 commits October 7, 2025 14:02
Signed-off-by: Faradawn Yang <[email protected]>
Signed-off-by: Faradawn Yang <[email protected]>
Signed-off-by: Faradawn Yang <[email protected]>
Signed-off-by: Faradawn Yang <[email protected]>
Signed-off-by: Faradawn Yang <[email protected]>
Signed-off-by: Faradawn Yang <[email protected]>
Signed-off-by: Faradawn Yang <[email protected]>
Signed-off-by: Faradawn Yang <[email protected]>
Signed-off-by: Faradawn Yang <[email protected]>
Signed-off-by: Faradawn Yang <[email protected]>
This reverts commit 196cf92.

Signed-off-by: Robin Kobus <[email protected]>
Signed-off-by: Faradawn Yang <[email protected]>
- Updated L0_Test.groovy to include auto_trigger for Qwen3Next.
- Added TestQwen3NextThinking class in test_llm_api_pytorch.py for accuracy testing.
- Updated l0_dgx_h100.yml to include new test case for Qwen3Next under specific conditions.

Signed-off-by: Robin Kobus <[email protected]>
Signed-off-by: Faradawn Yang <[email protected]>
Signed-off-by: Faradawn Yang <[email protected]>
Signed-off-by: Faradawn Yang <[email protected]>
Signed-off-by: Faradawn Yang <[email protected]>
This reverts commit 196cf92.

Signed-off-by: Robin Kobus <[email protected]>
Signed-off-by: Faradawn Yang <[email protected]>
@faradawn faradawn requested review from a team as code owners October 7, 2025 20:22
@faradawn
Copy link
Author

faradawn commented Oct 7, 2025

Hi @Funatiq, I did a rebase but it still had many file changes. Would you like to check and approve this new PR: #8181.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community want to contribute PRs initiated from Community

Projects

None yet

Development

Successfully merging this pull request may close these issues.