Skip to content

Fix: LLM API logits processor example comments #2962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Conversation

syuoni
Copy link
Collaborator

@syuoni syuoni commented Mar 20, 2025

This MR fixes LLM API logits processor example comments.

@syuoni
Copy link
Collaborator Author

syuoni commented Mar 20, 2025

/bot run

@syuoni syuoni self-assigned this Mar 20, 2025
@syuoni syuoni changed the base branch from main to dev-main-new March 20, 2025 13:42
@syuoni
Copy link
Collaborator Author

syuoni commented Mar 20, 2025

/bot run

@syuoni syuoni requested a review from kaiyux March 20, 2025 13:59
@syuoni
Copy link
Collaborator Author

syuoni commented Mar 21, 2025

/bot run

@niukuo
Copy link
Collaborator

niukuo commented Mar 21, 2025

/LLM/main/L0_MergeRequest_PR pipeline #182 completed with status: 'FAILURE'

@syuoni
Copy link
Collaborator Author

syuoni commented Mar 21, 2025

/bot run

@niukuo
Copy link
Collaborator

niukuo commented Mar 21, 2025

/LLM/main/L0_MergeRequest_PR pipeline #185 completed with status: 'FAILURE'

@syuoni syuoni changed the base branch from dev-main-new to main March 23, 2025 11:49
@syuoni
Copy link
Collaborator Author

syuoni commented Mar 23, 2025

/bot run

@niukuo
Copy link
Collaborator

niukuo commented Mar 23, 2025

PR_Github #191 [ run ] triggered by Bot

@niukuo
Copy link
Collaborator

niukuo commented Mar 23, 2025

PR_Github #191 [ run ] completed with state FAILURE

@kaiyux
Copy link
Member

kaiyux commented Mar 24, 2025

/bot run

@kaiyux
Copy link
Member

kaiyux commented Mar 24, 2025

@syuoni The DCO checking is failed - please sign off the commit by adding -s when commit, so the command becomes git commit -s -m "Msg"

@niukuo
Copy link
Collaborator

niukuo commented Mar 24, 2025

PR_Github #204 [ run ] triggered by Bot

Signed-off-by: Enwei Zhu <[email protected]>
@kaiyux
Copy link
Member

kaiyux commented Mar 24, 2025

@syuoni The DCO checking is failed - please sign off the commit by adding -s when commit, so the command becomes git commit -s -m "Msg"

Never mind, I rebased your branch and the DCO check seems to be passing.

@kaiyux
Copy link
Member

kaiyux commented Mar 24, 2025

/bot run

@niukuo
Copy link
Collaborator

niukuo commented Mar 24, 2025

PR_Github #207 [ run ] triggered by Bot

@niukuo
Copy link
Collaborator

niukuo commented Mar 24, 2025

PR_Github #204 [ run ] completed with state ABORTED

@kaiyux
Copy link
Member

kaiyux commented Mar 24, 2025

/bot skip --comment "style check passed on comment change"

@niukuo
Copy link
Collaborator

niukuo commented Mar 24, 2025

PR_Github #215 [ skip ] triggered by Bot

@niukuo
Copy link
Collaborator

niukuo commented Mar 24, 2025

PR_Github #207 [ run ] completed with state ABORTED

@niukuo
Copy link
Collaborator

niukuo commented Mar 24, 2025

PR_Github #215 [ skip ] completed with state SUCCESS

@ZhanruiSunCh
Copy link
Collaborator

/bot skip --comment "style check passed on comment change"

@niukuo
Copy link
Collaborator

niukuo commented Mar 24, 2025

PR_Github #226 [ skip ] triggered by Bot

@niukuo
Copy link
Collaborator

niukuo commented Mar 24, 2025

PR_Github #226 [ skip ] completed with state SUCCESS
Skipping testing for commit 7be8e60

@kaiyux kaiyux merged commit c03d598 into NVIDIA:main Mar 24, 2025
2 checks passed
@syuoni syuoni deleted the fix-doc branch March 24, 2025 04:39
yizhang-nv pushed a commit to yizhang-nv/TensorRT-LLM that referenced this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants