Skip to content

fix: Fix path to constraints.txt in bloom/requirements.txt #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

fix: Fix path to constraints.txt in bloom/requirements.txt #3003

merged 1 commit into from
Mar 24, 2025

Conversation

Pradeep-18062002
Copy link
Contributor

This PR fixes a broken path in:

examples/models/contrib/bloom/requirements.txt

which was referencing

 -c ../constraints.txt.

Since the file was moved deeper, the correct relative path is now

 -c ../../../constraints.txt

This change ensures proper installation of the example dependencies without file-not-found errors

@juney-nvidia
Copy link
Collaborator

Thanks for the contribution, @Pradeep-18062002 .
@byshiue @QiJune can you hep review this MR?

Thanks
June

@juney-nvidia juney-nvidia requested review from byshiue and QiJune March 24, 2025 04:25
@juney-nvidia juney-nvidia changed the title Fix path to constraints.txt in bloom/requirements.txt fix: Fix path to constraints.txt in bloom/requirements.txt Mar 24, 2025
@juney-nvidia
Copy link
Collaborator

@Pradeep-18062002 you can refer here to see whether you can pass the DCO check or not.
#2962 (comment)

@juney-nvidia juney-nvidia added the Community want to contribute PRs initiated from Community label Mar 24, 2025
@kaiyux kaiyux mentioned this pull request Mar 24, 2025
Closed
4 tasks
@kaiyux kaiyux force-pushed the fix-requirements-path branch from 3fdf2f6 to dfccba7 Compare March 24, 2025 05:24
@kaiyux
Copy link
Member

kaiyux commented Mar 24, 2025 •
edited
Loading

@Pradeep-18062002 The DCO failed with the error message

Expected "Pradeep Raj Prabhu Raj [[email protected]](mailto:[email protected])", but got "Pradeep Raj Prabhu Raj [[email protected]](mailto:[email protected])".

There is a slight difference in the mail addresses.

@kaiyux
Copy link
Member

kaiyux commented Mar 24, 2025

@Pradeep-18062002 Thanks a lot for the support!

@kaiyux
Copy link
Member

kaiyux commented Mar 24, 2025

/bot run

@Pradeep-18062002
Copy link
Contributor Author

@Pradeep-18062002 Thanks a lot for the support!

You're Most welcome

@niukuo
Copy link
Collaborator

niukuo commented Mar 24, 2025

PR_Github #244 [ run ] triggered by Bot

byshiue
byshiue approved these changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@byshiue byshiue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

QiJune
QiJune approved these changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niukuo
Copy link
Collaborator

niukuo commented Mar 24, 2025

PR_Github #244 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #241 completed with status: 'SUCCESS'

@kaiyux kaiyux force-pushed the fix-requirements-path branch from 3f51004 to 55be126 Compare March 24, 2025 09:44
@kaiyux
Copy link
Member

kaiyux commented Mar 24, 2025

/bot reuse-pipeline

@kaiyux kaiyux enabled auto-merge (squash) March 24, 2025 09:44
@niukuo
Copy link
Collaborator

niukuo commented Mar 24, 2025

PR_Github #282 [ reuse-pipeline ] triggered by Bot

@niukuo
Copy link
Collaborator

niukuo commented Mar 24, 2025

PR_Github #282 [ reuse-pipeline ] completed with state SUCCESS
Release Check Pipeline #75 failed
Reusing PR_Github #244 for commit 55be126

@kaiyux
Copy link
Member

kaiyux commented Mar 24, 2025

/bot reuse-pipeline

@niukuo
Copy link
Collaborator

niukuo commented Mar 24, 2025

PR_Github #295 [ reuse-pipeline ] triggered by Bot

@niukuo
Copy link
Collaborator

niukuo commented Mar 24, 2025

PR_Github #295 [ reuse-pipeline ] completed with state SUCCESS
Release Check Pipeline #77 failed
Reusing PR_Github #244 for commit 55be126

@kaiyux kaiyux force-pushed the fix-requirements-path branch from 55be126 to 16af288 Compare March 24, 2025 14:51
@kaiyux
Copy link
Member

kaiyux commented Mar 24, 2025

/bot reuse-pipeline

@niukuo
Copy link
Collaborator

niukuo commented Mar 24, 2025

PR_Github #313 [ reuse-pipeline ] triggered by Bot

@niukuo
Copy link
Collaborator

niukuo commented Mar 24, 2025

PR_Github #313 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #244 for commit 16af288

@kaiyux kaiyux merged commit 5b4a501 into NVIDIA:main Mar 24, 2025
2 checks passed
@juney-nvidia juney-nvidia added the Community Engagement help/insights needed from community label Apr 12, 2025
wu1du2 pushed a commit to wu1du2/TensorRT-LLM that referenced this pull request May 11, 2025
@Pradeep-18062002
Fix: wrong path to constraints.txt in bloom/requirements.txt (NVIDIA#…
9f13476 
…3003)

Signed-off-by: Pradeep Raj Prabhu Raj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byshiue byshiue byshiue approved these changes

@QiJune QiJune QiJune approved these changes

Assignees
No one assigned
Labels
Community Engagement help/insights needed from community Community want to contribute PRs initiated from Community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Pradeep-18062002 @juney-nvidia @kaiyux @niukuo @byshiue @QiJune