Skip to content

docs(agentic-ci): fix ModelFacade image method names in models.md #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreatnvidia merged 1 commit into from
Oct 19, 2026
Merged

docs(agentic-ci): fix ModelFacade image method names in models.md #1049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion architecture/models.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ The primary interface for generators. Holds a `ModelConfig`, `ModelClient`, opti

- **`completion` / `acompletion`** — consolidates kwargs from inference params, the call, and provider extras (`extra_body` is merged key by key in that order), forwards known request fields such as `tools` and `tool_choice` (adapters translate them per provider), warns about dropped kwargs, calls the client, tracks usage
- **`generate_text_embeddings` / `agenerate_text_embeddings`** — embedding generation
- **`image_generation` / `aimage_generation`** — image generation
- **`generate_image` / `agenerate_image`** — image generation
- **MCP tool loops** — when a tool config is active, processes tool calls from completions via `MCPFacade`, feeds results back, and tracks tool usage stats. A caller's `tool_choice` applies only until the first tool call, so a forced choice cannot keep the loop from ending

### ModelRegistry
Expand Down
Loading