Skip to content

docs(agentic-ci): fix ModelFacade image method names in models.md - #1049

Merged
andreatnvidia merged 1 commit into
mainfrom
agentic-ci/docs/docs-and-references-20261019-models-generate-image
Oct 19, 2026
Merged

andreatnvidia merged 1 commit into
mainfrom
agentic-ci/docs/docs-and-references-20261019-models-generate-image

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Summary

architecture/models.md lists the ModelFacade image methods as image_generation / aimage_generation. Those methods no longer exist. The current names in packages/data-designer-engine/src/data_designer/engine/models/facade.py are generate_image / agenerate_image.

This PR changes one line in the ModelFacade bullet list.

Verification

  • grep finds no image_generation or aimage_generation method on ModelFacade. The only similar match is the private helper _build_image_generation_request.
  • ModelFacade.generate_image and ModelFacade.agenerate_image are both defined in facade.py.

This is a docs-only change, so no tests were run.

馃 Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions
github-actions Bot requested a review from a team as a code owner October 19, 2026 08:23
@github-actions github-actions Bot added agentic-ci Created by agentic-ci automation agentic-ci/docs-and-references Agentic CI - docs-and-references suite labels Oct 19, 2026
@greptile-apps

greptile-apps Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This documentation correction is safe to merge.

Summary

Corrects the image method names in architecture/models.md.

  • The Models page lists the current image method names.

Reviews (1) 路 Last reviewed commit: "docs(agentic-ci): fix ModelFacade image ..." 路 Reviewed by Greptile

@andreatnvidia

Copy link
Copy Markdown
Contributor

/authorize-agentic-ci

@andreatnvidia
andreatnvidia merged commit 89ddef2 into main Oct 19, 2026
127 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentic-ci/docs-and-references Agentic CI - docs-and-references suite agentic-ci Created by agentic-ci automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant