Repository navigation
docs(agentic-ci): fix ModelFacade image method names in models.md - #1049
Merged
andreatnvidia merged 1 commit intoOct 19, 2026
Merged
andreatnvidia merged 1 commit into
andreatnvidia merged 1 commit into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
[Low impact] This documentation correction is safe to merge. SummaryCorrects the image method names in
Reviews (1) 路 Last reviewed commit: "docs(agentic-ci): fix ModelFacade image ..." 路 Reviewed by Greptile |
Contributor
|
/authorize-agentic-ci |
andreatnvidia
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
architecture/models.mdlists theModelFacadeimage methods asimage_generation/aimage_generation. Those methods no longer exist. The current names inpackages/data-designer-engine/src/data_designer/engine/models/facade.pyaregenerate_image/agenerate_image.This PR changes one line in the ModelFacade bullet list.
Verification
grepfinds noimage_generationoraimage_generationmethod onModelFacade. The only similar match is the private helper_build_image_generation_request.ModelFacade.generate_imageandModelFacade.agenerate_imageare both defined infacade.py.This is a docs-only change, so no tests were run.
馃 Generated with Claude Code