Develop -> Main (v0.1.1) #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lectrolyzer produced more h2.
…r to today's commercially available
…ing dt to stack_dict
Updating dryer loss and membrane thickness
Adds alkaline modeling capabilities and tests.
Reorganize file structure for BERT
* removed setup and added to pyproject * Updated CI workflow * WIP: Added CI and docs build * Added jupyterbook docs * Updated readme * change CI to install all
* reformatted * updated PEM schema and removed LCOH tests temporarily * updated alkaline modeling schema and alkaline Urev0 calc * update lcoh glue_code test regression values * added hydrogen loss from degradation and input toggle to choose that option * added LCA functions to stack.py * added eol_eff_percent_loss as degradation input for stack * added run_LCA functionto run_electrolyzer script * added more tracking variables to stack * updated all py file import paths * updated jupyter notebook import paths * added validators and minor fix in stack for cell type * added skeleton for cluster and cell classes * added generic base class * added example skeleton for simulation config * added file for power-curve function templates * updated inputs for Stack in test_stack * added import to fix tests to stack.py * removed empty PEM cell test * renamed test_cell to test_PEM_cell * updated validator format * removed files unrelated to primary feature-adds * reformatted bert.py * added back-in placeholder files * removed alkaline sources in alkaline model into md file * Typographical changes * minor cleanups to alkaline cell and stack * removed commented out code and added docstrings * fixed aep datadrame in bert.py * added more docstrings to stack.py * added comments to pem.py for faradaic coefficients --------- Co-authored-by: bayc <[email protected]> Co-authored-by: John Jasa <[email protected]>
johnjasa
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
isortpre-commit hookRelated issue, if one exists
Impacted areas of the software
Additional supporting information
Test results, if applicable