Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
74 commits
Select commit Hold shift + click to select a range
81b99f9
added updated degradation calcs
ZackTully Jan 25, 2023
8b39392
New degradation rates
ZackTully Feb 7, 2023
12f7860
updated test for new deg calcs
ZackTully Feb 10, 2023
ec863f5
updat pre-commit yaml
ZackTully Feb 10, 2023
f1c61b7
remove whitespace
ZackTully Feb 10, 2023
29e8928
Merge pull request #1 from ZackTully/fix/deg_rates
ZackTully Feb 11, 2023
6c9b16e
update test_regression
ZackTully Feb 15, 2023
3a1b668
fix test_regression
ZackTully Feb 15, 2023
8642ff4
fix test_regression
ZackTully Feb 15, 2023
491355a
troubleshooting tests
ZackTully Feb 15, 2023
ae62555
test_regression total h2 4 decimals
ZackTully Feb 15, 2023
c51f876
Merge branch 'develop' into fix/deg_rates
ZackTully Feb 15, 2023
761168e
Update test_run_electrolyzer.py
ZackTully Feb 15, 2023
916554a
Merge branch 'NREL:develop' into develop
ZackTully Feb 16, 2023
76f6e74
Merge pull request #2 from ZackTully/fix/deg_rates
ZackTully Feb 16, 2023
441b3b4
Merge pull request #3 from NREL/develop
ZackTully Feb 19, 2023
cb5a103
Merge branch 'NREL:develop' into develop
ZackTully Feb 22, 2023
b91c246
Added example #6, conversion efficiency
nRiccobo Apr 26, 2023
add505e
changed formatting for tests
elenya-grant May 17, 2023
b36e4dc
reformatted for cleaned up deg rates
elenya-grant May 17, 2023
b3d43ba
Merge branch 'develop' into develop
nRiccobo May 18, 2023
77ef9ee
delete duplicate example
ZackTully May 22, 2023
0e38f87
small formatting changes
ZackTully May 22, 2023
7c917cb
WIP adjust modeling schema for alkaline cells
ZackTully May 22, 2023
224535f
Bump isort version for pre-commit bugfix (#60)
camirmas Jun 12, 2023
daa7f94
alkaline example formatting
ZackTully Jul 9, 2023
7baf194
update test validation
ZackTully Jul 9, 2023
550e98c
update test_validation.py
ZackTully Jul 9, 2023
135aa34
Merge branch 'develop' into develop
nRiccobo Aug 2, 2023
b63d726
Merge pull request #52 from nRiccobo/develop
nRiccobo Aug 2, 2023
2aaf03a
updating test_run_electrolyzer with new modeling schema
ZackTully Aug 2, 2023
87dfcd1
fit_params difference
ZackTully Aug 3, 2023
8bbf71c
save for power_to_current debug
ZackTully Aug 3, 2023
cd4417c
troubleshooting before test_run_lcoh.py
ZackTully Aug 3, 2023
ccd7071
test_optimization new schema
ZackTully Aug 7, 2023
c189360
tidying up a bit
ZackTully Aug 7, 2023
89b5017
controller example debugging
ZackTully Aug 7, 2023
18a3e0f
changed modeling schema interface in test_optimization
ZackTully Aug 7, 2023
77b8248
removing unnecessary comment blocks and unused files
ZackTully Aug 8, 2023
4167add
updating examples for new schema
ZackTully Aug 8, 2023
37dfe92
Issue #61: Update Cathod Pressure to be 30bar
nRiccobo Aug 9, 2023
5489636
Had to update LCOH test because of changes to cell voltage. Life Tota…
nRiccobo Aug 18, 2023
dc98d55
add generic citation file
ZackTully Sep 19, 2023
13c52f8
Merge pull request #66 from nRiccobo/update/p_cathode
nRiccobo Sep 20, 2023
19285fe
delete unneeded comments
ZackTully Oct 18, 2023
e3b9e88
Merge remote-tracking branch 'origin/develop' into esg/alkaline
ZackTully Oct 18, 2023
f059e62
Merge remote-tracking branch 'origin/develop' into esg/alkaline
bayc Oct 18, 2023
5dece7c
resolve merge conflicts
ZackTully Oct 18, 2023
0830110
resolve merge conflicts
ZackTully Oct 18, 2023
474c21f
Updated dryer loss to 0.2%. Test stack lowered the kWh/kg. Test run_e…
nRiccobo Dec 7, 2023
3b1e6fb
Test lcoh results in a lower lcoh.
nRiccobo Dec 7, 2023
5338ccf
Updated membrane thickness in calc_ohmic_overpot. 20 microns is close…
nRiccobo Dec 7, 2023
b0718d3
Updated test stack and fit params. Needed to update example_01 by add…
nRiccobo Dec 7, 2023
a3098f7
Updated run_electrolyzer test. Hydrogen output increased
nRiccobo Dec 7, 2023
3cc0deb
Updated run_lcoh test. Results show a lower lcoh
nRiccobo Dec 7, 2023
9d6b62a
Merge pull request #72 from nRiccobo/develop
bayc Dec 20, 2023
35c93ad
Merge branch 'esg/alkaline' of https://github.com/ZackTully/electroly…
bayc Jan 26, 2024
4150924
Merge remote-tracking branch 'origin/develop' into esg/alkaline
bayc Jan 26, 2024
847058a
updating reg test value after changes from merge
bayc Jan 26, 2024
5ed2cbd
changed PEM_Cell class to PEMCell
bayc Jan 26, 2024
fb611dc
updating relative imports to explicit
bayc Jan 26, 2024
ca5eea2
updating Alkaline_Cell class to AlkalineCell
bayc Jan 26, 2024
d3a171a
adding typing for stack.cell
bayc Jan 26, 2024
8d7e659
fixing linting
bayc Jan 26, 2024
6f0acf5
removing commented code
bayc Jan 26, 2024
155f39c
Add alkaline electrolyzer model (#62)
bayc Jan 26, 2024
e913ad8
WIP: Reformatting repo into BERT structure
johnjasa Feb 3, 2025
9d7004f
updated all py file import paths
elenya-grant Feb 3, 2025
9459bcd
updated jupyter notebook import paths
elenya-grant Feb 3, 2025
b4e83fa
updated pre-commit config
elenya-grant Feb 10, 2025
583eb36
Merge pull request #79 from elenya-grant/dev/bert_reorg
johnjasa Feb 19, 2025
319dae9
Prep for release (#82)
johnjasa Mar 18, 2025
638d890
Update pyproject.toml
johnjasa Mar 19, 2025
0d88b3a
Feature/bert basic (#81)
elenya-grant Sep 24, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Testing

on: [ push, pull_request ]

jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.11"]

steps:
- uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v3
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -e .[all]
- name: Create env file
run: |
touch .env
- name: Run tests
run: |
pytest .
20 changes: 20 additions & 0 deletions .github/workflows/ci_docs.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: Test Documentation Build

on: [ push, pull_request ]

jobs:
build:

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.11
- name: Install dependencies
run: |
pip install ".[develop]"
- name: Build documentation
run: |
jupyter-book build docs/
44 changes: 0 additions & 44 deletions .github/workflows/continuous-integration-workflow.yaml

This file was deleted.

13 changes: 8 additions & 5 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,21 +1,24 @@
default_language_version:
python: python3

repos:
- repo: https://github.com/timothycrosley/isort
rev: 5.10.1
- repo: https://github.com/pycqa/isort
rev: 5.12.0
hooks:
- id: isort
name: isort
stages: [commit]
stages: [pre-commit]

- repo: https://github.com/psf/black
rev: 22.3.0
hooks:
- id: black
name: black
stages: [commit]
stages: [pre-commit]
language_version: python3

- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.3.0
rev: v4.5.0
hooks:
- id: trailing-whitespace
- id: end-of-file-fixer
Expand Down
14 changes: 14 additions & 0 deletions CITATION.cff
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
cff-version: 0.0.0
message: "If you use this software, please cite it as below."
authors:
- family-names: "Mona"
given-names: "Lisa"
orcid: "https://orcid.org/0000-0000-0000-0000"
- family-names: "Bot"
given-names: "Hew"
orcid: "https://orcid.org/0000-0000-0000-0000"
title: "My Research Software"
version: 2.0.4
doi: 10.5281/zenodo.1234
date-released: 2017-12-18
url: "https://github.com/github-linguist/linguist"
50 changes: 0 additions & 50 deletions README.rst

This file was deleted.

56 changes: 56 additions & 0 deletions docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
# Contributing

We welcome contributions in the form of bug reports, bug fixes, improvements to the documentation,
ideas for enhancements (or the enhancements themselves!).

You can find a [list of current issues](https://github.com/NREL/electrolyzer/issues) in the project's
GitHub repo. Feel free to tackle any existing bugs or enhancement ideas by submitting a
[pull request](https://github.com/NREL/electrolyzer/pulls).

## Bug Reports

* Please include a short (but detailed) Python snippet or explanation for reproducing the problem.
Attach or include a link to any input files that will be needed to reproduce the error.
* Explain the behavior you expected, and how what you got differed.

## Pull Requests

* Please reference relevant GitHub issues in your commit message using `GH123` or `#123`.
* Changes should be [PEP8](http://www.python.org/dev/peps/pep-0008/) compatible.
* Keep style fixes to a separate commit to make your pull request more readable.
* Docstrings are required and should follow the
[Google style](https://www.sphinx-doc.org/en/master/usage/extensions/example_google.html).
* When you start working on a pull request, start by creating a new branch pointing at the latest
commit on [main](https://github.com/NREL/electrolyzer).
* The electrolyzer copyright policy is detailed in the [`LICENSE`](https://github.com/NREL/electrolyzer/blob/main/LICENSE).

## Documentation

When contributing new features, or fixing existing capabilities, be sure to add and/or update the
docstrings as needed to ensure the documentation site stays up to date with the latest changes.

To build the documentation locally, the following command can be run in your terminal in the docs
directory of the repository:

```bash
sh build_book.sh
```

In addition to generating the documentation, be sure to check the results by opening the following
path in your browser: `file://<path-to-electrolyzer>/electrolyzer/docs/_build/html/index.html`.

```{note}
If the browser appears to be out of date from what you expected to built, please try the following, roughly in order:
1. Reload the page a few times
2. Clear your browser's cache and open the page again.
3. Delete the `_build` folder and rebuild the docs
```

## Tests

The test suite can be run using `pytest .`

When you push to your fork, or open a PR, your tests will be run against the
[Continuous Integration (CI)](https://github.com/NREL/electrolyzer/actions) suite. This will start a build
that runs all tests on your branch against multiple Python versions, and will also test
documentation builds.
20 changes: 0 additions & 20 deletions docs/Makefile

This file was deleted.

67 changes: 67 additions & 0 deletions docs/_config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
# Book settings
# Learn more at https://jupyterbook.org/customize/config.html

title: Electrolyzer
author: National Renewable Energy Laboratory
# logo: logo.png
copyright: "2025"
only_build_toc_files: false
# exclude_patterns: [_build, Thumbs.db, .DS_Store, "**.ipynb_checkpoints", .github]

# Force re-execution of notebooks on each build.
# See https://jupyterbook.org/content/execute.html
execute:
execute:
execute_notebooks: auto
timeout: -1 # better for longer running notebooks
merge_streams: true # keeps unsynchronized cell outputs in a single output cell
exclude_patterns:
- _build
- Thumbs.db
- DS_Store
- "**.ipynb_checkpoints"

# Define the name of the latex output file for PDF builds
latex:
latex_documents:
targetname: book.tex

# Information about where the book exists on the web
repository:
url: https://github.com/NREL/electrolyzer
path_to_book: docs
branch: main

# Add GitHub buttons to your book
# See https://jupyterbook.org/customize/config.html#add-a-link-to-your-repository
html:
use_issues_button: true
use_repository_button: true
baseurl: https://nrel.github.io/electrolyzer/

sphinx:
extra_extensions:
- "sphinx.ext.autodoc"
- "sphinx.ext.autosummary"
- "sphinx.ext.napoleon"

config:
language: 'python'
autosummary_generate: true
autodoc_default_options:
members: true
member-order: bysource
undoc-members: true
private-members: true
# special-members: true
# inherited-members
# show-inheritance
# ignore-module-all
# imported-members: true
# exclude-members
# class-doc-from
# no-value
autodoc_typehints: description
napoleon_use_admonition_for_notes: true
napoleon_use_rtype: false
nb_merge_streams: true
10 changes: 10 additions & 0 deletions docs/_toc.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Table of contents
# Learn more at https://jupyterbook.org/customize/toc.html

format: jb-book
root: intro
parts:
- caption: Getting Started
chapters:
- file: installing
- file: CONTRIBUTING
Loading