Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namelist switches and parameter file changes ahead of upcoming PR on Johnson & Berry electron transport model #1344

Merged
merged 4 commits into from
Feb 27, 2025

Conversation

JessicaNeedham
Copy link
Contributor

@JessicaNeedham JessicaNeedham commented Feb 26, 2025

This PR sets groundwork for later changes that will implement the Johson & Berry electron transport model in FATES - see issue #1337 . This PR adds the fnps parameter to the parameter file - the later PR will remove it as a hard coded value. Based on comments in #1337 it remains a global parameter (not PFT dependent). This PR also adds in FATES side changes for a namelist switch that switches between FvCB 1980 and JB 2021 formulations for electron transport response to irradiance. To be synchronized with HLM side changes which are about to be merged.

Collaborators:

@glemieux @rgknox @alistairrogers

Expectation of Answer Changes:

Should be b4b

Checklist

No testing yet

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:
No testing yet

@JessicaNeedham
Copy link
Contributor Author

Updated to make the fnps parameter pft-dependent.

Add the file to start from the previous API38 default update from sci.1.81.1_api.38.0.0
@glemieux
Copy link
Contributor

glemieux commented Feb 27, 2025

Regression testing on derecho against fates-sci.1.81.1_api.38.0.0-ctsm5.3.027 is B4B as expected. This was tested with ESCOMP/CTSM#2904 which now includes an API update and default parameter file up associated with this PR.

Results: /glade/u/home/glemieux/ctsm/tests_pr1344-fates-026

@glemieux
Copy link
Contributor

glemieux commented Feb 27, 2025

Regression testing on izumi against fates-sci.1.81.1_api.38.0.0-ctsm5.3.027 is B4B as expected as well.

Results: home/glemieux/ctsm/tests_0227-083900iz

@glemieux glemieux merged commit 6903518 into NGEET:main Feb 27, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants