Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Johnson and Berry 2021 electron transport model option #1350

Open
wants to merge 81 commits into
base: main
Choose a base branch
from

Conversation

JessicaNeedham
Copy link
Contributor

Description:

This PR adds the Johnson and Berry 2021 model of electron transport response to irradiance as an option. Julien Lamour et al. have found this formulation has a better goodness of fit to gas exchange than the original FvCB model. See issue #1337 for details and discussion.

Note this needs to come in after #1262 . Parameter file and namelist option changes came in with #1344 . This requires the parameter file to namelist migration on the HLM side. Right now I am testing with this branch which has the new electron transport model switch but none of the other new ones.

The current configuration compiles and runs with the JohnsonBerry2021 namelist option switched on, but I haven't evaluated it yet. I'm still working on adding a history variable to track photosynthesis limitation by Rubisco and RuBP.

Collaborators:

@alistairrogers @JulienLamour @rgknox @rosiealice @glemieux

Expectation of Answer Changes:

With the FvCB1980 namelist option this should be b4b.
With the new JohnsonBerry namelist option we expect lower photosynthesis at intermediate irradiance.

Checklist

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results:

Compiles but no formal testing yet.

rgknox added 30 commits October 14, 2024 12:10
@JessicaNeedham JessicaNeedham added the status: Not Ready The author is signaling that this PR is a work in progress and not ready for integration. label Mar 5, 2025
@rgknox
Copy link
Contributor

rgknox commented Mar 5, 2025

This is based on branch leaf_funcunit_tests, here is the diff until the former is integrated:

rgknox/fates@leaf_funcunit_tests...JessicaNeedham:fates:jb-electron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: Not Ready The author is signaling that this PR is a work in progress and not ready for integration.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants