-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Johnson and Berry 2021 electron transport model option #1350
Open
JessicaNeedham
wants to merge
81
commits into
NGEET:main
Choose a base branch
from
JessicaNeedham:jb-electron
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…af_funcunit_tests
…ng inventory files
…ling method to work with BB for type 4
Co-authored-by: Gregory Lemieux <[email protected]>
…ates and unneeded text
Refactors and cleans up the patch numbering and nocomp checks
This is based on branch leaf_funcunit_tests, here is the diff until the former is integrated: rgknox/fates@leaf_funcunit_tests...JessicaNeedham:fates:jb-electron |
…ed gross assimilation diagnostics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status: Not Ready
The author is signaling that this PR is a work in progress and not ready for integration.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the Johnson and Berry 2021 model of electron transport response to irradiance as an option. Julien Lamour et al. have found this formulation has a better goodness of fit to gas exchange than the original FvCB model. See issue #1337 for details and discussion.
Note this needs to come in after #1262 . Parameter file and namelist option changes came in with #1344 . This requires the parameter file to namelist migration on the HLM side. Right now I am testing with this branch which has the new electron transport model switch but none of the other new ones.
The current configuration compiles and runs with the JohnsonBerry2021 namelist option switched on, but I haven't evaluated it yet. I'm still working on adding a history variable to track photosynthesis limitation by Rubisco and RuBP.
Collaborators:
@alistairrogers @JulienLamour @rgknox @rosiealice @glemieux
Expectation of Answer Changes:
With the FvCB1980 namelist option this should be b4b.
With the new JohnsonBerry namelist option we expect lower photosynthesis at intermediate irradiance.
Checklist
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Documentation
Test Results:
Compiles but no formal testing yet.