Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant restart #279

Merged
merged 27 commits into from
Oct 16, 2023
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
5ee74e5
Remove redundant restart
widhalmt Sep 28, 2023
a759794
Only restart Elasticsearch if it was already running
widhalmt Sep 28, 2023
099024d
Check API twice
widhalmt Sep 28, 2023
6d1c7a6
Restrict Elasticsearch restarts
widhalmt Sep 29, 2023
0bd410b
Restart Logstash only when needed
widhalmt Sep 29, 2023
2da2cb9
Fix variable for Elasticsearch fresh start
widhalmt Sep 29, 2023
2140b71
Fix variable names
widhalmt Sep 29, 2023
e75994b
Restart Kibana only when needed
widhalmt Sep 29, 2023
c2a3976
Only restart when all start tasks haven't changed
widhalmt Sep 30, 2023
6f3115c
Give more ressources to test containers
widhalmt Oct 2, 2023
28a1ddb
Typo
widhalmt Oct 2, 2023
02f96e7
Clear cache at end of each role
widhalmt Oct 2, 2023
87a4a18
Workarounds for low ressources on GitHub runners
widhalmt Oct 2, 2023
1929d9f
Typo
widhalmt Oct 2, 2023
510624f
Minimizing services for small CI/CD runners
widhalmt Oct 5, 2023
d0823f6
Add debug tasks
widhalmt Oct 10, 2023
a75e06e
Activate logging in another scenario
widhalmt Oct 10, 2023
74671b2
Don't fail when there's nothing to explain
widhalmt Oct 10, 2023
dd8b1c5
Set watermarks persistent and transient
widhalmt Oct 10, 2023
3ab78f5
Fix curl and add debug
widhalmt Oct 11, 2023
7ff8527
Lint
widhalmt Oct 11, 2023
18753c7
Move watermark change
widhalmt Oct 11, 2023
9831cd9
Remove debug and throttleing
widhalmt Oct 11, 2023
8258929
Undo changes to throtteling.
widhalmt Oct 11, 2023
cf54655
Typo
widhalmt Oct 11, 2023
2f5a802
Merge branch 'main' into fix/redundant_restarts-278
widhalmt Oct 11, 2023
51967e2
Replace unnecessary shell with command
widhalmt Oct 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Restart Kibana only when needed
widhalmt committed Sep 29, 2023

Verified

This commit was signed with the committer’s verified signature.
widhalmt Thomas Widhalm
commit e75994b39c3ae509ffbae216140220efa9afe53b
3 changes: 3 additions & 0 deletions roles/kibana/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -18,6 +18,9 @@ kibana_cert_will_expire_soon: false
kibana_sniff_on_start: false
kibana_sniff_on_connection_fault: false

kibana_freshstart:
changed: false

# "global" variables for all roles
elasticstack_release: 8
elasticstack_full_stack: true
2 changes: 2 additions & 0 deletions roles/kibana/handlers/main.yml
Original file line number Diff line number Diff line change
@@ -4,3 +4,5 @@
ansible.builtin.service:
name: kibana
state: restarted
when:
- not kibana_freshstart.changed | bool
1 change: 1 addition & 0 deletions roles/kibana/tasks/main.yml
Original file line number Diff line number Diff line change
@@ -82,6 +82,7 @@
state: started
enabled: yes
when: kibana_enable | bool
register: kibana_freshstart

# the following is useful when running tests or extra tasks that need to
# have Kibana running. Escape it on Rocky8, because it gets time out with Elastic 8