Remove redundant restart #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to restart Elasticseach after this task. Everything is set in a similar task earlier. This one is only to change the start bevaviour to a safer one (not reinitializing the cluster). The change is only needed during restarts, so whenever Elasticsearch is restarted, the new version will be used. fixes #278
once for availability, once for data
Only restart when we really need it. Especially not after a fresh start.
|
Seems like the Elasticsearch cluster still has problems syncing. I'll withdraw the request for review and get back to Draft. |
widhalmt
commented
Oct 11, 2023
widhalmt
commented
Oct 11, 2023
This was referenced Oct 13, 2023
Merged
lcndsmr
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restarting Elasticsearch takes quite a while and may lead to connection issues as well as sync issues. So keeping restarts to a minimum is important. These changes will make sure that, even when the
Restart Elasticsearchhandler is notified, it will only restart if Elasticsearch was running before. If there's a fresh start (after reconfiguration) we don't need to restart again.Same goes for Logstash and Kibana. Some restarts of these tools happen fairly fast. But others (like after fresh installs or updates) will trigger internal jobs that should not be intercepted by another restart.
Beats restart very fast and as far as I know there's not a big downside to restarting them right after the first start so I didn't include them in the change.
Additionally, this PR will make sure some tasks in
verify.ymlof the full stack are only run when the service to be checked is actually running on this node. This helps with spreading services over nodes to save ressources.Since GitHub hosted runners are quite low on ressources we can't run every service on every node in a cluster setup anymore. So this PR will make sure that only Elasticsearch runs everywhere and the others are spread out.
Caches get cleared after every role in during a Molecule test. This helps with saving ressources, too.
Elasticsearch still won't sync all shards due to full volumes, the watermarks for Elasticseach are set to extremely high volumes so that the cluster can at least get into sync.
fixes #278
fixes #141
fixes #194