-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mass Metadata Parsing #2079
base: master
Are you sure you want to change the base?
Mass Metadata Parsing #2079
Conversation
Added button to pr Update mainwindow.ui Update mainwindow.ui Added button to pr
Fixed clang formatting on downloadstab.cpp
This should probably display some kind of popup if there are more than a few missing files (maybe 5 or something like that) because 1) this could lead to bad performances due to the directory watcher - |
Added a warning to show the user how many files will be fetched, and that it will cause stutter and consume API requests. Not disabling the dir watcher while querying metadata can cause a silent crash, which doesn't seem to be present when disabling it |
Your change makes it impossible to refresh for less than 5 files I think. |
The new dialog box hijacked the function and skipped the fetch if there were less than 5 files. Now directly runs if there are 5 files or less, and shows the dialog if there are more than 5\
My bad. Should be fixed now |
Obviously not every file in the download pane necessarily has to come from Nexus. I think it may be worth adding a metadata flag to indicate if it was already queried. This should avoid running checks on non-Nexus files after an attempt has been made. |
What we probably should do is allow for some multiselect context options so grouping of files can be checked and not necessarily the entire list. Although that's not necessarily in the scope of this change. |
The original PR I built off of mentioned that as well, with this being a stopgap measure. Full transparency, this is my first time reading or writing C++ or using Qt so I'm totally lost in the metadata writing functions. As far as I can see, the best way to do this would be to make a stub
If checks are failed on the Mod ID. It feels like this should be added into the QueryInfo functions in general, though, rather than tied to the button. |
This is a dumb question, but is there any way for me, as someone who knows nothing about coding, to put this into my MO2 setup? Could really use this feature as I'm moving my Skyrim setup from NMM over to MO2. |
@kcrrr You'd have to build the mo2 application with this edit. You could always try to set that up via https://github.com/ModOrganizer2/mob @KenJyn76 To be clear I'd like to see the addition of the metadata flag before I would personally approve this in order to mitigate unnecessary repeat queries. The multiselect bit can be added later. |
I liked the idea of #1861, but could not get it built. Fixed up and implemented the functionality started over there. Adds a button opposite the Refresh button in the Downloads tab that queries every mod in the Downloads list that does not have a .meta file associated with it.