Mass Metadata Parsing: Prevent re-querying and manual prompts to enter missing data #2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanFeenstra
force-pushed
the
queryinfo-patch-1
branch
from
968c044 to
8338b81
Compare
|
How does this handle it if the Nexus API goes down or fails? We probably don't want to conflate a temporary outage with the Nexus having no info. |
Al12rs
previously approved these changes
Dec 13, 2024
|
Looks like it currently treats missing info due to connection problems the same way as no info because the mods are not on Nexus, so that still needs to be addressed. There should probably also be an error message if you try to query info while MO2 is in offline mode. I'll look into it. |
Added button to pr Update mainwindow.ui Update mainwindow.ui Added button to pr
Fixed clang formatting on downloadstab.cpp
The new dialog box hijacked the function and skipped the fetch if there were less than 5 files. Now directly runs if there are 5 files or less, and shows the dialog if there are more than 5\
JonathanFeenstra
force-pushed
the
queryinfo-patch-1
branch
from
8338b81 to
a44c0f8
Compare
|
I addressed both issues in my last 2 commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #2079. I added a
m_AskIfNotFoundflag toDownloadInfowhich is set tofalsewhen batch-querying the download list, to prevent multiple pop-ups from appearing, asking to fill in missing data such as mod IDs and games if they weren't detected automatically. Instead, it will now create meta-files where the missing info is left blank. The repository is also left blank to prevent re-querying, which can only be done if it's set to "Nexus".