Fix FF7 remake crash when no mods are selected #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In function `_active_mod_mappings`, `pak_priority_digits` was calculated based on log base 10 of number of mod paths for selected mods. When no mods are selected (or no paths present in selected mods), this takes log(0) resulting in a ValueError. But no `pak_priority_digits` is needed in this case, so this commit fixes by early exiting in case of no mod paths prior to computing `pak_priority_digits`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In function
_active_mod_mappings,pak_priority_digitswas calculated based on log base 10 of number of mod paths for selected mods. When no mods are selected (or no paths present in selected mods), this takes log(0) resulting in a ValueError. Butpak_priority_digitsis not needed in this case, so this commit fixes by early exiting in case of no mod paths prior to computingpak_priority_digits.Example crash:
