Skip to content

fix: preserve aliases from memoryrefget #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MilesCranmer merged 1 commit into from
Jun 10, 2026
Merged

fix: preserve aliases from memoryrefget #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/auto/defs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ function _populate_registry!()
(Core, :memoryrefnew, (2,), (), ()),
(Core, :memoryref, (2,), (), ()),
(Core, :memoryrefoffset, (2,), (), ()),
(Core, :memoryrefget, (), (), ()),
(Core, :memoryrefget, (2,), (), ()),
(Core, :memoryrefset!, (), (2,), (3,)),
(Core, :memoryrefswap!, (), (2,), (3,)),
(Core, :memoryrefmodify!, (), (2,), (4,)),
Expand Down
11 changes: 11 additions & 0 deletions test/auto_borrow_checker_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,17 @@
@test_throws BorrowCheckError _bc_bang_mutates_second_bad()
end

@testset "array element extraction preserves aliases" begin
@safe function _bc_array_getindex_alias_bad(outer::Vector{Vector{Int}})
a = outer[1]
b = outer[1]
push!(a, 2)
return b
end

@test_throws BorrowCheckError _bc_array_getindex_alias_bad([[1]])
end

@testset "adversarial overloads (no special-casing overloadables)" begin
mutable struct _BCGetPropMutates
x::Vector{Int}
Expand Down
Loading