Skip to content

fix: preserve aliases from memoryrefget#74

Merged
MilesCranmer merged 1 commit into
MilesCranmer:mainfrom
MilesCranmerBot:mcbot/fix-memoryrefget-ret-alias
Jun 10, 2026
Merged

fix: preserve aliases from memoryrefget#74
MilesCranmer merged 1 commit into
MilesCranmer:mainfrom
MilesCranmerBot:mcbot/fix-memoryrefget-ret-alias

Conversation

@MilesCranmerBot

Copy link
Copy Markdown
Contributor

Registers Core.memoryrefget as returning an alias of its memory reference argument. Without this, repeated outer[1] array element extraction is treated as fresh values and misses aliasing violations.

Adds the E1 regression from the Claude experiment branch through the public @safe path.

Tested:

  • BORROWCHECKER_ONLY_AUTO=true BORROWCHECKER_TESTITEM="Auto @safe" julia --project=. -e 'using Pkg; Pkg.test()'

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
@MilesCranmer

Copy link
Copy Markdown
Owner

@MilesCranmerBot can you make another PR that makes the nightly tests not fail the CI? allow-fail or whatever

@MilesCranmer MilesCranmer merged commit 010c5af into MilesCranmer:main Jun 10, 2026
5 of 6 checks passed
@MilesCranmerBot

Copy link
Copy Markdown
Contributor Author

Opened #76.

Change: the nightly Julia setup/build/test steps now soft-fail at the step level, so nightly-ubuntu-x64 should stop reporting a failed check run. The prior job-level continue-on-error made the workflow green but still left that individual check red.

Commit: MilesCranmerBot/BorrowChecker.jl@902cdd4
Verification: git diff --check; Ruby YAML parse of .github/workflows/CI.yml. New PR checks are running.

github-actions Bot referenced this pull request Jun 10, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants