Skip to content

Alexolinhager/gl advance hydro debugging #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexolinhager wants to merge 5 commits into from
Closed

Alexolinhager/gl advance hydro debugging #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1247e82
Establish initial alarm framework
alexolinhager Sep 3, 2024
5ea7382
Complete effectivePressure averaging over coupling interval
alexolinhager Sep 4, 2024
727dcd9
Check master dt/SGH coupling interval compatibility
alexolinhager Sep 5, 2024
f123500
Remove effectivePressure set to zero at timeinterval
alexolinhager Sep 16, 2024
5c7e2f3
Implement test
alexolinhager Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions components/mpas-albany-landice/src/Registry.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1170,7 +1170,7 @@ is the value of that variable from the *previous* time level!
<!-- ================ -->

<!-- Variables related to ice sheet geometry -->
<var_struct name="geometry" time_levs="1">
<var_struct name="geometry" time_levs="1">
<var name="bedTopography" type="real" dimensions="nCells Time" units="m above datum"
description="Elevation of ice sheet bed. Once isostasy is added to the model, this should become a state variable."
/>
Expand Down Expand Up @@ -1201,7 +1201,10 @@ is the value of that variable from the *previous* time level!
<var name="cellMask" type="integer" dimensions="nCells Time" units="none"
description="bitmask indicating various properties about the ice sheet on cells. cellMask only needs to be a restart field if config_allow_additional_advance = false (to keep the mask of initial ice extent)"
/>
<var name="edgeMask" type="integer" dimensions="nEdges Time" units="none"
<var name="cellMaskOld" type="integer" dimensions="nCells Time" units="none"
description="cellMask from previous master timestep"
/>
<var name="edgeMask" type="integer" dimensions="nEdges Time" units="none"
description="bitmask indicating various properties about the ice sheet on edges."
/>
<var name="vertexMask" type="integer" dimensions="nVertices Time" units="none" time_levs="2"
Expand Down
16 changes: 12 additions & 4 deletions components/mpas-albany-landice/src/Registry_subglacial_hydro.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@
description="The maximum allowable time step in seconds. If the allowable time step determined by the adaptive CFL calculation is longer than this, then the model will specify config_SGH_max_adaptive_timestep as the time step instead. Defaults to 100 years (in seconds)."
possible_values="Any non-negative real value."
/>
<nml_option name="config_SGH_tangent_slope_calculation" type="character" default_value="from_normal_slope" units="unitless"
<nml_option name="config_SGH_coupling_interval" type="character" default_value="0000-00-00_00:00:01" units="unitless"
description="Time interval at which the SGH model is called by MALI. If set to an interval less than the master timestep, config_SGH_coupling_interval will be superceded by the master timestep. If greater than the master timestep, config_adaptive_timestep_force_interval will be set equal to config_SGH_coupling_interval."
possible_values="Any time interval of the format 'YYYY-MM-DD_HH:MM:SS'"
/>
<nml_option name="config_SGH_tangent_slope_calculation" type="character" default_value="from_normal_slope" units="unitless"
description="Selection of the method for calculating the tangent component of slope at edges.
'from_vertex_barycentric' interpolates scalar values from cell centers to vertices using the barycentric interpolation routine in operators (mpas_cells_to_points_using_baryweights) and then calculates the slope between vertices. It works for obtuse triangles, but will not work correctly across the edges of periodic meshes.
'from_vertex_barycentric_kiteareas' interpolates scalar values from cell centers to vertices using barycentric interpolation based on kiterea values and then calculates the slope between vertices. It will work across the edges of periodic meshes, but will not work correctly for obtuse triangles.
Expand Down Expand Up @@ -180,8 +184,10 @@
<!-- convenience variables -->
<var name="effectivePressureSGH" type="real" dimensions="nCells Time" units="Pa"
description="effective ice pressure in subglacial hydrology system" />
<var name="effectivePressure" type="real" dimensions="nCells Time" units="Pa" packages="higherOrderVelocity"
description="Effective pressure used in basal friction calculation. If subglacial hydrology model is active, this will be effectivePressureSGH averaged over the subglacial hydrology model timestepping subcycles. If subglacial hydrology model is inactive, this will come from a file or a parameterization."/>
<var name="effectivePressure" type="real" dimensions="nCells Time" units="Pa" packages="higherOrderVelocity" default_value="-1e36"
description="Effective pressure used in basal friction calculation. If subglacial hydrology model is active, this will be effectivePressureSGH averaged over the interval defined by config_SGH_coupling_interval. If subglacial hydrology model is inactive, this will come from a file or a parameterization."/>
<var name="effectivePressureTimeCycleAvg" type="real" dimensions="nCells Time" units="Pa"
description="effectivePressureSGH averaged over the subglacial hydrology model timestepping subcycle." />
<var name="hydropotential" type="real" dimensions="nCells Time" units="Pa"
description="hydropotential in subglacial hydrology system" />
<var name="waterFlux" type="real" dimensions="nEdges Time" units="m{^2} s^{-1}"
Expand Down Expand Up @@ -246,7 +252,9 @@
description="time step length limited by pressure equation scheme in subglacial hydrology system" />
<var name="deltatSGH" type="real" dimensions="Time" units="s"
description="time step used for evolving subglacial hydrology system" />
<var name="distGroundingLineDischargeCell" type="real" dimensions="Time nCells" units="m^{3} s^{-1}"
<var name="deltatSGHaccumulated" type="real" dimensions="Time" units="s"
description="accumulated deltatSGH throughout SGH coupling interval" />
<var name="distGroundingLineDischargeCell" type="real" dimensions="Time nCells" units="m^{3} s^{-1}"
description="distributed discharge across the grounding line, summed from grounding line edges to adjacent ungrounded cell. Values from all edges are summed if multiple grounding line edges border a single ungrounded cell" />
<var name="totalGroundingLineDischargeCell" type="real" dimensions="Time nCells" units="m^{3} s^{-1}"
description="total (channel + dist.) discharge across the grounding line, summed from grounding line edges to adjacent ungrounded cell. Values from all edges are summed if multiple grounding line edges border a single ungrounded cell" />
Expand Down
Loading