Alexolinhager/gl advance hydro debugging#126
Closed
alexolinhager wants to merge 5 commits into
Closed
Conversation
Established the initial framework to implement the SGH coupling interval alarm. Not compilable at this point
Introduces a new subroutine to the SGH model that ensures config_adaptive_interval_force_interval divides evenly into config_SGH_coupling_interval
Removes line that sets effectivePressure equal to zero at the start of each timecycle; otherwise, effectivePressure was zero until the very end of the timecycle. Instead, effectivePressure is now initialized to be equal to effectivePressureSGH if there is no effectivePressure field in the input file. A defualt value of -1e36 is given to effectivePressure to flag whether the field is empty at the start of the run.
|
After consultation with @alexolinhager , closing because redundant with #125 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.