sn-manager updates

sn-manager/README.md

@@ -5,19 +5,29 @@ SuperNode Process Manager with Automatic Updates
 ## Installation
 
 Download and install sn-manager:
+Note: Supported on Linux x86_64 (amd64). Other architectures are not yet supported.
 ```bash
+
 # Download and extract
-curl -L https://github.com/LumeraProtocol/supernode/v2/releases/latest/download/supernode-linux-amd64.tar.gz | tar -xz
+# Always fetch the latest stable release asset
+curl -L https://github.com/LumeraProtocol/supernode/releases/latest/download/supernode-linux-amd64.tar.gz | tar -xz
 
-# Install sn-manager only (supernode will be managed automatically)
-chmod +x sn-manager
-sudo mv sn-manager /usr/local/bin/
+# Install sn-manager to a user-writable location (enables self-update)
+install -D -m 0755 sn-manager "$HOME/.sn-manager/bin/sn-manager"
 
 # Verify
-sn-manager version
+"$HOME/.sn-manager/bin/sn-manager" version
+
+# Optional: add to PATH for convenience
+echo 'export PATH="$HOME/.sn-manager/bin:$PATH"' >> ~/.bashrc
+source ~/.bashrc && hash -r
+
+# Confirm the path used resolves to our install first
+command -v -a sn-manager
+readlink -f "$(command -v sn-manager)"
 ```
 
-Note: SuperNode binary will be automatically downloaded and managed by sn-manager during initialization.
+Note: SuperNode binary will be automatically downloaded and managed by sn-manager during initialization. Installing sn-manager under your home directory allows it to auto-update itself.
 
 ## Systemd Service Setup
 
@@ -31,7 +41,7 @@ After=network-online.target
 
 [Service]
 User=<YOUR_USER>
-ExecStart=/usr/local/bin/sn-manager start
+ExecStart=/home/<YOUR_USER>/.sn-manager/bin/sn-manager start
 Restart=on-failure
 RestartSec=10
 LimitNOFILE=65536
@@ -47,14 +57,43 @@ sudo systemctl enable --now sn-manager
 journalctl -u sn-manager -f
 ```
 
+Stop/start later or restart after changes:
+```bash
+sudo systemctl stop sn-manager
+sudo systemctl start sn-manager
+
+# or
+sudo systemctl restart sn-manager
+journalctl -u sn-manager -f
+```
+
+### Ensure PATH points to user install (Required for self-update)
+
+To ensure self-update works and avoid conflicts, make sure your shell resolves to the user-writable install:
+
+```bash
+# List all sn-manager binaries found on PATH (our path should be first)
+command -v -a sn-manager
+
+# Remove any global copy (e.g., /usr/local/bin/sn-manager)
+sudo rm -f /usr/local/bin/sn-manager || true
+
+# Clear shell command cache and verify again
+hash -r
+command -v -a sn-manager
+readlink -f "$(command -v sn-manager)"
+```
+
+The systemd unit uses an absolute `ExecStart` pointing to your home directory, so the service will always run the intended binary regardless of PATH.
+
 ## Initialization
 
 ### Interactive Mode
 ```bash
 sn-manager init
 ```
 
-> !!! If Supernode was already initialized before, use `sn-manager init` without parameters OR with SN-Manager only flags (see bellow)!!!
+> !!! If SuperNode was already initialized before, use `sn-manager init` without parameters OR with SN-Manager-only flags (see below)!!!
 
 ### Non-Interactive Mode
 
@@ -92,11 +131,18 @@ sn-manager init -y \
   --chain-id lumera-testnet-2
 ```
 
+Disable auto-upgrade non-interactively:
+```bash
+sn-manager init -y --auto-upgrade false
+```
+
 ### Flags
 
+Note: Unrecognized flags to `sn-manager init` are passed through to the underlying `supernode init`.
+
 **SN-Manager flags:**
 - `--force` - Override existing configuration
-- `--auto-upgrade` - Enable automatic updates
+- `--auto-upgrade` or `--auto-upgrade true|false` - Enable/disable automatic updates (default: enabled)
 - `--check-interval` - Update check interval in seconds
 
 **SuperNode flags (passed through):**
@@ -116,15 +162,95 @@ sn-manager init -y \
 ## Commands
 
 - `init` - Initialize sn-manager and SuperNode
-- `start` - Start SuperNode
-- `stop` - Stop SuperNode
+- `start` - Start sn-manager and SuperNode
+- `stop` - Stop sn-manager and SuperNode
 - `status` - Show status
 - `version` - Show version
 - `get <version>` - Download version
 - `use <version>` - Switch version
 - `ls` - List installed versions
-- `ls-remote` - List available versions
+- `ls-remote` - List available stable versions
 - `check` - Check for updates
+- `supernode start` - Start SuperNode (requires sn-manager running)
+- `supernode stop` - Stop SuperNode and prevent auto-restart
+- `supernode status` - Show SuperNode status
+
+## Version Update Scenarios
+
+The auto-updater follows stable-only, same-major update rules and defers updates while the gateway is busy. Summary:
+
+| Current | Available | Auto-Upgrade Enabled | Auto Updates? | Manual Option |
+|---|---|---|---|---|
+| v1.7.1 | v1.7.4 (stable) | Yes | ✅ | — |
+| v1.7.1-beta | v1.7.1 (stable) | Yes | ✅ | — |
+| v1.7.4 | v1.8.0 (stable) | Yes | ❌ | `sn-manager get v1.8.0 && sn-manager use v1.8.0` |
+| v1.7.4 | v1.8.0-rc1 (pre-release) | Yes | ❌ | `sn-manager get v1.8.0-rc1 && sn-manager use v1.8.0-rc1` |
+| v1.7.4 | v1.7.4 (stable) | Yes | ❌ | — |
+| v1.7.5 | v1.7.4 (stable) | Yes | ❌ | — |
+| Any | Any | No | ❌ | `sn-manager get [version] && sn-manager use [version]` |
+| Any | Any | Yes, but gateway busy | ❌ (deferred) | Manual allowed |
+| Manager v1.7.0 | Release v1.7.4 (contains sn-manager) | Yes | ✅ (self-update) | Reinstall if needed |
+| Manager v1.7.x | Release v1.8.0 | Yes | ❌ (self-update) | Reinstall new sn-manager |
+
+Mechanics and notes:
+- Stable-only: auto-updater targets latest stable GitHub release (non-draft, non-prerelease).
+- Same-major only: SuperNode and sn-manager auto-update only when the latest is the same major version as the current.
+- Gateway-aware: updates are applied only when the gateway reports no running tasks; otherwise they are deferred.
+- Gateway errors: repeated check failures over a 5-minute window request a clean SuperNode restart (no version change) to recover.
+- Combined tarball: when updating, sn-manager downloads a single tarball once, then updates itself first (if eligible), then installs/activates the new SuperNode version.
+- Config is updated to reflect the new `updates.current_version` after a successful SuperNode update.
+- Manual installs: you can always override with `sn-manager get <version>` and `sn-manager use <version>`; pre-releases are supported manually.
+
+## Start/Stop Behavior
+
+sn-manager start and supernode start clear the stop marker; supernode stop sets it. How the manager and SuperNode processes behave for each command, plus systemd nuances:
+
+| Action | Manager | SuperNode | Marker | systemd (unit uses `Restart=on-failure`) |
+|---|---|---|---|---|
+| `sn-manager start` | Starts manager ✅ | Starts if no stop marker ✅ | Clears `.stop_requested` if present | Start via `systemctl start sn-manager` when running under systemd |
+| `sn-manager stop` | Stops manager ✅ | Stops (graceful, then forced if needed) ✅ | — | Will NOT be restarted by systemd (clean exit) ❌ |
+| `sn-manager status` | Reads PID | Reports running/not and versions | — | — |
+| `sn-manager supernode start` | Stays running | Starts SuperNode ✅ | Removes `.stop_requested` | — |
+| `sn-manager supernode stop` | Stays running | Stops SuperNode ✅ | Writes `.stop_requested` | — |
+| SuperNode crash | Stays running | Auto-restarts after backoff ✅ | Skipped if `.stop_requested` present ❌ | — |
+| Manager crash | Exits abnormally | — | — | systemd restarts manager ✅ |
+
+Notes:
+- Clean exit vs. systemd: If systemd started sn-manager and you run `sn-manager stop`, the manager exits cleanly. With `Restart=on-failure`, systemd does not restart it. Use `systemctl start sn-manager` (or `systemctl restart sn-manager`) to run it again. If you want automatic restarts after clean exits, change the unit to `Restart=always` (not generally recommended as it fights the `stop` intent).
+- Stop marker: `.stop_requested` prevents automatic SuperNode restarts by the manager until cleared. `sn-manager supernode start` clears it; `sn-manager start` also clears it on launch.
+- PID files: Manager writes `~/.sn-manager/sn-manager.pid`; SuperNode writes `~/.sn-manager/supernode.pid`. Stale PID files are detected and cleaned up.
+
+## Migration for Existing sn-manager Users
+
+If you already run sn-manager, you can align with this guide without re-initializing.
+
+1) Check your current install
+- Show paths: `command -v -a sn-manager` and `readlink -f "$(command -v sn-manager)"`.
+- Required for self-update: install at `~/.sn-manager/bin/sn-manager` (must be user-writable).
+- If you currently use `/usr/local/bin/sn-manager`, self-update will not work reliably. Switch to the user path and remove the global copy:
+  `sudo rm -f /usr/local/bin/sn-manager && hash -r`
+
+2) Reinstall to user path (required for self-update)
+```bash
+curl -L https://github.com/LumeraProtocol/supernode/releases/latest/download/supernode-linux-amd64.tar.gz | tar -xz
+install -D -m 0755 sn-manager "$HOME/.sn-manager/bin/sn-manager"
+echo 'export PATH="$HOME/.sn-manager/bin:$PATH"' >> ~/.bashrc
+source ~/.bashrc && hash -r
+sn-manager version
+```
+
+3) Keep existing data
+- No changes to `~/.supernode` or `~/.sn-manager` are required.
+- Do not re-run `supernode init`; your keys and config remain intact.
+
+4) Update or create the systemd unit
+- Use the unit from this README. Ensure `ExecStart` points to the intended binary path and set `Environment=HOME=...` and `WorkingDirectory=...` for your user.
+- With `Restart=on-failure`, `sn-manager stop` will cleanly exit and systemd will not restart it; start again with `sudo systemctl start sn-manager`.
+
+5) Verify and adopt
+- Manager status: `sn-manager status`
+- Check updates: `sn-manager check`
+
 
 ## Configuration
 
@@ -137,9 +263,24 @@ updates:
 ```
 
 **Reset:**
+
+Reset managed data while keeping the installed sn-manager binary:
+```bash
+sudo systemctl stop sn-manager
+rm -rf ~/.supernode/
+rm -rf ~/.sn-manager/binaries ~/.sn-manager/downloads ~/.sn-manager/current ~/.sn-manager/config.yml
+sn-manager init
+```
+
+Full reset (also removes the sn-manager binary; you will need to reinstall it):
 ```bash
 sudo systemctl stop sn-manager
 rm -rf ~/.sn-manager/ ~/.supernode/
+# Reinstall sn-manager as shown in Installation, then:
 sn-manager init
 ```
 
+## Notes
+
+- By default, `sn-manager start` starts both the manager and SuperNode. You can later control SuperNode independently with `sn-manager supernode start|stop|status`.
+- Auto-updates use the latest stable release and apply within the same major version. A single release bundle is downloaded and used to update both sn-manager and SuperNode.

sn-manager/cmd/check.go

@@ -1,13 +1,14 @@
 package cmd
 
 import (
-	"fmt"
+    "fmt"
+    "strings"
 
-	"github.com/LumeraProtocol/supernode/v2/sn-manager/internal/config"
-	"github.com/LumeraProtocol/supernode/v2/sn-manager/internal/github"
-	"github.com/LumeraProtocol/supernode/v2/sn-manager/internal/updater"
-	"github.com/LumeraProtocol/supernode/v2/sn-manager/internal/utils"
-	"github.com/spf13/cobra"
+    "github.com/LumeraProtocol/supernode/v2/sn-manager/internal/config"
+    "github.com/LumeraProtocol/supernode/v2/sn-manager/internal/github"
+    "github.com/LumeraProtocol/supernode/v2/sn-manager/internal/updater"
+    "github.com/LumeraProtocol/supernode/v2/sn-manager/internal/utils"
+    "github.com/spf13/cobra"
 )
 
 var checkCmd = &cobra.Command{
@@ -31,26 +32,34 @@ func runCheck(cmd *cobra.Command, args []string) error {
 
 	fmt.Println("Checking for updates...")
 
-	// Create GitHub client
-	client := github.NewClient(config.GitHubRepo)
+    // Create GitHub client
+    client := github.NewClient(config.GitHubRepo)
 
 	// Get latest stable release
 	release, err := client.GetLatestStableRelease()
 	if err != nil {
 		return fmt.Errorf("failed to check for stable updates: %w", err)
 	}
 
-	fmt.Printf("\nLatest release: %s\n", release.TagName)
-	fmt.Printf("Current version: %s\n", cfg.Updates.CurrentVersion)
+    fmt.Printf("\nLatest release: %s\n", release.TagName)
+    fmt.Printf("Current version: %s\n", cfg.Updates.CurrentVersion)
+    // Report manager version and if it would update under the same policy
+    mv := strings.TrimSpace(appVersion)
+    if mv != "" && mv != "dev" && !strings.EqualFold(mv, "unknown") {
+        managerWould := utils.SameMajor(mv, release.TagName) && utils.CompareVersions(mv, release.TagName) < 0
+        fmt.Printf("Manager version: %s (would update: %v)\n", mv, managerWould)
+    } else {
+        fmt.Printf("Manager version: %s\n", appVersion)
+    }
 
-	// Compare versions
-	cmp := utils.CompareVersions(cfg.Updates.CurrentVersion, release.TagName)
+    // Compare versions
+    cmp := utils.CompareVersions(cfg.Updates.CurrentVersion, release.TagName)
 
 	if cmp < 0 {
 		// Use the same logic as auto-updater to determine update eligibility
-		managerHome := config.GetManagerHome()
-		autoUpdater := updater.New(managerHome, cfg)
-		wouldAutoUpdate := autoUpdater.ShouldUpdate(cfg.Updates.CurrentVersion, release.TagName)
+        managerHome := config.GetManagerHome()
+        autoUpdater := updater.New(managerHome, cfg, appVersion)
+        wouldAutoUpdate := autoUpdater.ShouldUpdate(cfg.Updates.CurrentVersion, release.TagName)
 
 		if wouldAutoUpdate {
 			fmt.Printf("\n✓ Update available: %s → %s\n", cfg.Updates.CurrentVersion, release.TagName)

sn-manager/cmd/get.go

@@ -2,6 +2,7 @@ package cmd
 
 import (
 	"fmt"
+	"log"
 	"os"
 	"path/filepath"
 
@@ -29,16 +30,13 @@ func runGet(cmd *cobra.Command, args []string) error {
 
 	var targetVersion string
 	if len(args) == 0 {
-		release, err := client.GetLatestRelease()
+		release, err := client.GetLatestStableRelease()
 		if err != nil {
 			return fmt.Errorf("failed to get latest release: %w", err)
 		}
 		targetVersion = release.TagName
 	} else {
-		targetVersion = args[0]
-		if targetVersion[0] != 'v' {
-			targetVersion = "v" + targetVersion
-		}
+		targetVersion = normalizeVersionTag(args[0])
 	}
 
 	fmt.Printf("Target version: %s\n", targetVersion)
@@ -54,28 +52,20 @@ func runGet(cmd *cobra.Command, args []string) error {
 	}
 
 	tempFile := filepath.Join(managerHome, "downloads", fmt.Sprintf("supernode-%s.tmp", targetVersion))
-
-	var lastPercent int
-	progress := func(downloaded, total int64) {
-		if total > 0 {
-			percent := int(downloaded * 100 / total)
-			if percent != lastPercent && percent%10 == 0 {
-				fmt.Printf("\rProgress: %d%%", percent)
-				lastPercent = percent
-			}
-		}
-	}
 
+	progress, done := newDownloadProgressPrinter()
 	if err := client.DownloadBinary(downloadURL, tempFile, progress); err != nil {
 		return fmt.Errorf("download failed: %w", err)
 	}
-	fmt.Println()
+	done()
 
 	if err := versionMgr.InstallVersion(targetVersion, tempFile); err != nil {
 		return fmt.Errorf("install failed: %w", err)
 	}
 
-	os.Remove(tempFile)
+	if err := os.Remove(tempFile); err != nil && !os.IsNotExist(err) {
+		log.Printf("Warning: failed to remove temp file: %v", err)
+	}
 	fmt.Printf("✓ Installed %s\n", targetVersion)
 	return nil
-}
+}