Merged
Conversation
j-rafique
approved these changes
Aug 27, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements comprehensive updates to the sn-manager system, introducing self-updating capabilities, improved process monitoring, and enhanced command structure. The changes enable sn-manager to update both itself and SuperNode from a single release tarball, add robust process supervision with automatic restart capabilities, and provide granular control over SuperNode lifecycle.
Key changes:
- Self-updating capability for sn-manager with combined tarball downloads
- Enhanced process monitoring and supervision with automatic crash recovery
- New command structure with dedicated SuperNode control commands
- Improved version comparison using full semantic versioning rules
Reviewed Changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| sn-manager/internal/version/manager.go | Implements streaming binary installation and improved error handling with cleanup |
| sn-manager/internal/utils/version.go | Adds comprehensive semantic versioning support with pre-release handling |
| sn-manager/internal/updater/updater_test.go | Removes entire test suite (1200+ lines) |
| sn-manager/internal/updater/updater.go | Major refactor for combined self-update and SuperNode update functionality |
| sn-manager/internal/manager/manager.go | Adds process monitoring, supervision, and automatic restart capabilities |
| sn-manager/internal/github/client.go | Enhances GitHub client with tarball support and improved error handling |
| sn-manager/internal/config/config.go | Adds configuration constants and defaults |
| sn-manager/go.mod | Removes test dependencies |
| sn-manager/cmd/*.go | Multiple command files implementing new SuperNode control structure |
| sn-manager/README.md | Comprehensive documentation updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.