This repository has been archived by the owner on Feb 8, 2023. It is now read-only.
Dashing: Publish both to imu/data and imu/data_raw. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This more closely resembles what REP 145 says, which is that imu/data_raw should publish without an orientation estimate while imu/data should publish *with* an orientation estimate. It's actually cheap to do this, since if there are no subscribers ROS 2 doesn't actually send any data on the wire. While we are in here, change the prefix of the temperature, fluid_pressure, and rpy to have "imu" so we are consistent. Signed-off-by: Chris Lalancette <[email protected]>
|
Thanks again for merging! |
|
@clalancette If possible, could you create this pull request again. I have to revert this commit to merge pull request #34 . Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This more closely resembles what REP 145 says, which is that
imu/data_raw should publish without an orientation estimate
while imu/data should publish with an orientation estimate.
It's actually cheap to do this, since if there are no subscribers
ROS 2 doesn't actually send any data on the wire.
While we are in here, change the prefix of the temperature,
fluid_pressure, and rpy to have "imu" so we are consistent.
Signed-off-by: Chris Lalancette [email protected]