-
Notifications
You must be signed in to change notification settings - Fork 2
Improve GTK interface readability with larger fonts and white text #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0977362
Improve GTK interface readability with larger fonts and white text
kenvandine 6fc8133
fixed typo s/vender/vendor/g
kenvandine 1a1eb7f
Improve GTK interface readability with larger fonts and white text
kenvandine 9bc47dc
Update src/css/style.css
kenvandine 1651da2
Merge remote-tracking branch 'refs/remotes/origin/font_improvements' …
kenvandine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This CSS approach deviates from the established codebase convention of using class-based selectors for styling. The existing CSS rules in this file (.button-next-last-page, .button-green, .text-error) all use specific class selectors that are explicitly applied in Python code, providing fine-grained control and avoiding unintended side effects. Using broad element-type selectors (window, label, button, entry, row) breaks this pattern and may have unforeseen consequences across the application. Consider following the existing convention by creating specific CSS classes (e.g., .large-text, .high-contrast) and applying them to elements that need enhanced readability.