Improve GTK interface readability with larger fonts and white text#60
Improve GTK interface readability with larger fonts and white text#60kenvandine wants to merge 5 commits into
Conversation
Add global CSS rules for window, label, button, entry, and row elements to use 14pt font size and white text color for better contrast on the dark background. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR attempts to improve GTK interface readability by adding global CSS rules that set font size to 14pt and text color to white for common UI elements. The application uses GTK4 with the Adwaita dark theme.
Changes:
- Added global CSS styling for window, label, button, entry, and row elements with 14pt font and white text color
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /* Global font and color settings for readability */ | ||
| window, label, button, entry, row { | ||
| font-size: 14pt; | ||
| color: white; | ||
| } |
There was a problem hiding this comment.
This CSS approach deviates from the established codebase convention of using class-based selectors for styling. The existing CSS rules in this file (.button-next-last-page, .button-green, .text-error) all use specific class selectors that are explicitly applied in Python code, providing fine-grained control and avoiding unintended side effects. Using broad element-type selectors (window, label, button, entry, row) breaks this pattern and may have unforeseen consequences across the application. Consider following the existing convention by creating specific CSS classes (e.g., .large-text, .high-contrast) and applying them to elements that need enhanced readability.
| window, label, button, entry, row { | ||
| font-size: 14pt; | ||
| color: white; | ||
| } | ||
|
|
There was a problem hiding this comment.
The row selector is overly broad and will affect all GTK row elements, including Adw.ActionRow widgets used extensively throughout the application (in sysinfo.py, specinfo.py, manualtest.py, check_packages.py, and completion pages). Adwaita ActionRows have their own carefully designed styling for dark theme with proper contrast and visual hierarchy. Forcing white text color on these elements may create visual inconsistencies or reduce readability on action rows with different backgrounds. Consider using more specific selectors or removing row from this global rule to preserve Adwaita's default ActionRow styling.
| window, label, button, entry, row { | |
| font-size: 14pt; | |
| color: white; | |
| } | |
| window, label, button, entry { | |
| font-size: 14pt; | |
| color: white; | |
| } | |
| row { | |
| font-size: 14pt; | |
| } |
Add global CSS rules for window, label, button, entry, and row elements to use 14pt font size and white text color for better contrast on the dark background. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…into font_improvements
Add global CSS rules for window, label, button, entry, and row elements to use 14pt font size and white text color for better contrast on the dark background.