Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kgo): drop kube-rbac-proxy, expose metrics by default for 1.5+ #1243

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Jan 30, 2025

What this PR does / why we need it:

Follow up for Kong/gateway-operator#956

Changes:

  • remove kube-rbac-proxy container for KGO 1.5+
  • expose metrics by default on 0.0.0.0:8080

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@pmalek pmalek added this to the KGO v1.5.x milestone Jan 30, 2025
@pmalek pmalek self-assigned this Jan 30, 2025
@pmalek pmalek force-pushed the kgo-drop-kube-rbac-proxy branch from 3bef375 to 151f11c Compare January 30, 2025 10:54
@pmalek pmalek force-pushed the kgo-drop-kube-rbac-proxy branch from 151f11c to c40589d Compare January 30, 2025 11:07
@pmalek pmalek changed the title feat(kgo): drop kube-rbac-proxy, expose metrics by default feat(kgo): drop kube-rbac-proxy, expose metrics by default for 1.5+ Jan 30, 2025
@pmalek pmalek marked this pull request as ready for review February 3, 2025 12:37
@pmalek pmalek requested a review from a team as a code owner February 3, 2025 12:37
@pmalek pmalek merged commit bdb2fb4 into main Feb 3, 2025
34 checks passed
@pmalek pmalek deleted the kgo-drop-kube-rbac-proxy branch February 3, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants